Repository navigation
Add a type parameter for ufunc ntypes property - #351
Merged
avalentino merged 1 commit intoOct 7, 2026
Merged
Conversation
Previously the template for the generic ufunc type-check-only subtypes declared the return type of the `ntypes` property to be `Literal[0]` unconditionally, but at runtime the `ntypes` of a `pyerfa` ufunc can also return `1`. The return type should therefore not be hardcoded but instead specified by a type parameter.
avalentino
approved these changes
Oct 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On current
mainthe template for the generic ufunc type-check-only subtypes declares the return type of thentypesproperty to beLiteral[0]unconditionally. At runtime the value can be0or1depending on which template is used for creating the ufunc:pyerfa/erfa/define_ufunc_user_dtype.templ
Line 2 in 343b9c8
pyerfa/erfa/define_ufunc.templ
Line 2 in 343b9c8
The code that chooses the template is
pyerfa/erfa_generator.py
Lines 497 to 505 in 343b9c8
so the
ntypesreturn type should be a type parameter likewise determined by theuser_dtypeproperty of the correspondingFunctioninerfa_generator.This change will allow using the ufunc type annotation template for ufuncs with
ntypes=1.