Skip to content

Expose pathfinding scoring fee config#955

Open
benthecarman wants to merge 1 commit into
lightningdevkit:mainfrom
benthecarman:expose-router-cfg
Open

Expose pathfinding scoring fee config#955
benthecarman wants to merge 1 commit into
lightningdevkit:mainfrom
benthecarman:expose-router-cfg

Conversation

@benthecarman

Copy link
Copy Markdown
Contributor

Applications need to tune route selection for different fee and reliability preferences while continuing to use ldk-node's default router. This makes the ProbabilisticScoringFeeParameters public so users can customize it to their needs.

Applications need to tune route selection for different fee and
reliability preferences while continuing to use ldk-node's default
router. This makes the ProbabilisticScoringFeeParameters public so users
can customize it to their needs.
@ldk-reviews-bot

ldk-reviews-bot commented Jul 2, 2026

Copy link
Copy Markdown

👋 I see @tnull was un-assigned.
If you'd like another reviewer assignment, please click here.

@ldk-reviews-bot ldk-reviews-bot requested a review from tnull July 2, 2026 01:34
@tnull

tnull commented Jul 2, 2026

Copy link
Copy Markdown
Collaborator

Applications need to tune route selection for different fee and reliability preferences while continuing to use ldk-node's default router.

No, I disagree with this. LDK's scorer parameters are very obscure and super confusing to 99% of users. I don't think we should expose them as an API and leave it up to the users to understand and attempt to 'improve their routing' as they very likely to mess things up even further or at least don't actually improve things.

If we think the parameters could be improved, we should rather adjust the defaults (in LDK or LDK Node) on the basis of actual benchmarks, A:B testing, simulations, or other data-driven models.

@tnull tnull removed their request for review July 2, 2026 08:58
@benthecarman

Copy link
Copy Markdown
Contributor Author

If we think the parameters could be improved, we should rather adjust the defaults (in LDK or LDK Node) on the basis of actual benchmarks, A:B testing, simulations, or other data-driven models.

I agree but feel users should be able to do the same for themselves.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants