chore: Simplify making HTTP requests. - #3364
Merged
Merged
Conversation
karlseguin
force-pushed
the
nikneym/samesite-strict-bypass
branch
from
September 1, 2026 23:28
be441b5 to
07198b7
Compare
If you look at #3293, you'll see a relatively contained change that has to touch over 20 files. The issue is that every HttpClient.newRequest needs to provide a lot of data. But `newRequest` takes a 2nd parameter: the HttpClient.Owner. If we make that Owner a little smarter, we can start to remove some of the individual fields needed in newRequest. For example, we can still allow a callsite to pass frame_id but, by default, we can use the owner's frame_id (which is what we want in most cases).
karlseguin
force-pushed
the
owner-consolidation
branch
from
September 2, 2026 00:17
0550d09 to
ed88bd7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR sits ontop of #3293
If you look at #3293, you'll see a relatively contained change that has to touch over 20 files. The issue is that every
HttpClient.newRequestneeds to provide a lot of data. ButnewRequesttakes a 2nd parameter: theHttpClient.Owner. If we put a bit more information inOwnerwe can use that as a default for more request fields. For example, we can still allow a caller to passframe_idbut, by default, we can use the owner's frame_id (which is what we want in most cases).