lint: don't let the runner's Chrome apt source fail the libsecret install - #922
Merged
Conversation
…tall The lint job runs apt-get update before installing libsecret-1-dev, and apt-get update exits non-zero if any configured source fails a hash check. The ubuntu runner image ships Google's Chrome apt source, which this job never installs from and which intermittently serves a Packages index that does not match its Release file. When that happens the whole job dies in setup, before npm or a single lint rule runs — twice in a row today, with the identical hash mismatch both times. Remove that source before updating. Nothing about what gets installed changes; only an unrelated third-party mirror loses the ability to veto it. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
Contributor
Greptile SummaryThis PR makes the lint workflow resilient to intermittent failures from the unused Google Chrome apt repository.
Confidence Score: 5/5The PR appears safe to merge because the removed apt source is not used elsewhere in the lint job. The change isolates apt setup from an unrelated Chrome repository while preserving the required
|
| Filename | Overview |
|---|---|
| .github/workflows/lint.yml | Removes an unused third-party apt source before installing libsecret-1-dev, without affecting later lint-job dependencies. |
Reviews (1): Last reviewed commit: "lint: don't let the runner's Chrome apt ..." | Re-trigger Greptile
AaryamanBhute
approved these changes
Sep 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
Lint Code & Documentationjob runssudo apt-get update && sudo apt-get install -y libsecret-1-devbefore anything else.apt-get updateexits non-zero if any configured source fails a hash check — and theubuntu-latestrunner image ships Google's Chrome apt source, which this job never installs from.When that mirror is mid-republish it serves a
Packages.gzthat doesn't match its ownReleasefile, and the whole job dies in setup beforenpm cior a single lint rule runs. That happened on #919 twice in a row today, ten minutes apart, with the identical hash mismatch both times:Every check that actually exercises the spec on that PR — breaking-change detection, both OpenAPI builds, preview, Mintlify — was green. The lint job was red only because an unrelated third-party mirror had a veto over it.
What changed
One step. The Chrome apt source list is removed before
apt-get update:Nothing about what gets installed changes.
libsecret-1-devstill installs from Ubuntu's own archive; a mirror this job doesn't use just loses the ability to fail it.Test plan
libsecret-1-dev..github/workflows/is not in the Lint workflow's ownpaths:filter, so the real lint job won't run on this PR;dummy.ymlreports the check instead. The actual validation is add the sandbox authorization reversal and expiry simulators to the spec #919 going green once it's rebased onto this.🤖 Generated with Claude Code
Generated by Claude Code