Repository navigation
Count invalid server-generated upload IDs - #3304
Merged
nicolaslopezbravo merged 5 commits intoOct 8, 2026
Merged
nicolaslopezbravo merged 5 commits into
nicolaslopezbravo merged 5 commits into
Conversation
Clients cannot correct malformed IDs produced during upload finalization. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Classify generated IDs at the existing REST mapping boundary so operation callbacks retain their original exceptions. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Count invalid generated upload IDs independently of a trusted, default-off HTTP classification gate. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Use a default-off frontend property to control HTTP classification while counting generated ID failures independently. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #3304 +/- ##
=============================================
- Coverage 64.24% 50.75% -13.50%
+ Complexity 10398 8713 -1685
=============================================
Files 840 939 +99
Lines 71755 80824 +9069
Branches 8611 9752 +1141
=============================================
- Hits 46099 41022 -5077
- Misses 23004 36399 +13395
- Partials 2652 3403 +751 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Count server-generated invalid IDs separately while preserving HTTP status mapping and callback exceptions. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
SophieGuo410
approved these changes
Oct 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add
FrontendRestRequestService.GeneratedBlobIdErrorto countInvalidBlobIdfailures while consuming server-generated upload IDs, including ID conversion and permanent-blob finalization.Track generated-ID processing stages so invalid client-supplied IDs, including stitch chunk IDs, are excluded from the counter.
HTTP status codes, SLO accounting, callback exceptions, storage writes, cleanup, and retry behavior remain unchanged.
Excluding client-supplied IDs
BLOB_ID_IS_SERVER_GENERATEDis set only after a successful router upload/stitch result. Client-supplied stitch chunk IDs are validated before that point; failures propagate without setting the marker.The counter increments only when both the marker is
trueand the error isRouterErrorCode.InvalidBlobId. The marker is cleared after successful generated-ID processing, before subsequent response handling.Tests inject failures at router, ID-conversion, and TTL-finalization stages, verifying zero increments for router-stage input failures and one increment for qualifying generated-ID failures. These tests verify the callback boundary; they do not exercise malformed chunk IDs through the real stitch parser.
Testing Done
Validated on JDK 11:
Coverage includes exactly-once metric increments, exclusion of client-supplied invalid IDs and unrelated failures, unchanged HTTP classification and exception causes, successful-path marker cleanup, and asynchronous ID conversion.
Copilot assisted with implementation and tests.