chore: 完善 dde-appearance dconfig 描述信息 - #280
Merged
Merged
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideUpdates the dconfig schema metadata for dde-appearance by restoring/adding proper English descriptions, adding corresponding Chinese descriptions, and replacing Chinese name placeholders, without changing any functional settings or JSON structure. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
mhduiy
marked this pull request as draft
August 6, 2026 13:02
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
mhduiy
force-pushed
the
agent/developer/0ad93f61
branch
2 times, most recently
from
August 6, 2026 14:04
369fea4 to
b59d74e
Compare
mhduiy
marked this pull request as ready for review
August 7, 2026 02:17
1. Replace 16 name[zh_CN] placeholder entries with readable Chinese names in misc/dconfig/org.deepin.dde.appearance.json 2. Restore English description to master values and add description[zh_CN] for 21 keys (16 placeholder + 5 secondary) 3. For 2 edge keys whose master description was Chinese with no English original, draft an English description and move the Chinese into description[zh_CN] 4. Preserve value defaults and JSON structure; only name[zh_CN], description, and description[zh_CN] change, with no logic or interface changes Log: Refined dde-appearance dconfig descriptions, keeping English and adding Chinese zh_CN Influence: 1. Verify the dconfig schema loads without JSON errors 2. Confirm English description and Chinese description[zh_CN] both display in dconfig-editor, with name[zh_CN] labels unchanged 3. Ensure all key default values and structure fields remain unchanged chore: 完善 dde-appearance dconfig 描述信息 1. 将 misc/dconfig/org.deepin.dde.appearance.json 中 16 个 name[zh_CN] 占位符替换为直观的中文名称 2. 对 16 个原占位 key 与 5 个 §1.2 key：description 字段恢复为 master 511dc06 的原始英文值，并新增 description[zh_CN] 字段写入中文描述 3. 对 2 个边缘 key（globalThemeOverride、irregularFontOverride）：原始 description 本为中文无英文原文，补拟英文 description 并将中文移入 description[zh_CN] 4. value/serial/flags/permissions/visibility/global/name 及 JSON 结构均保持原样，不涉及逻辑/接口改动 Log: 完善 dde-appearance 项目 dconfig 描述信息，保留英文并补中文 zh_CN 描述 Influence: 1. 验证 dconfig schema 可正常加载，无 JSON 错误 2. 在 dconfig-editor 中确认英文 description 与中文 description[zh_CN] 均正常显示，且 name[zh_CN] 中文标签不变 3. 确认各 key 默认值及结构字段未被改动 PMS: TASK-393847
mhduiy
force-pushed
the
agent/developer/0ad93f61
branch
from
August 7, 2026 02:24
b59d74e to
c0ff0f2
Compare
deepin pr auto review★ 总体评分：100分■ 【总体评价】
■ 【详细分析】
■ 【改进建议代码示例】 --- a/misc/dconfig/org.deepin.dde.appearance.json
+++ b/misc/dconfig/org.deepin.dde.appearance.json
@@ -14,7 +14,8 @@
"serial": 0,
"flags": [],
"name": "Font_Standard",
- "name[zh_CN]": "*****",
+ "name[zh_CN]": "标准字体",
"description": "The standard font for desktop",
+ "description[zh_CN]": "桌面环境使用的标准字体",
"permissions": "readwrite",
"visibility": "private" |
robertkill
approved these changes
Aug 7, 2026
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: mhduiy, robertkill The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
概述
完善
dde-appearance项目 dconfig schema (misc/dconfig/org.deepin.dde.appearance.json) 的描述信息：保留英文description并新增description[zh_CN]字段存放中文描述，同时将 16 个name[zh_CN]占位符*****替换为直观的中文名称。改动范围
misc/dconfig/org.deepin.dde.appearance.json（41 增 / 18 删）name[zh_CN]、description（恢复为 master 原始英文值）与新增description[zh_CN]（中文）三类文案字段globalThemeOverride、irregularFontOverride）：原description本为中文、无英文原文，补拟英文description并将中文移入description[zh_CN]value默认值及 JSON 结构、permissions/visibility/flags/serial/global/name等字段保持原样，不涉及任何逻辑/接口改动说明
*****占位符残留，23 个 key 均含description[zh_CN]。369fea4，其代码树与最终提交逐字节一致，仅 commit message 文案调整）。PMS: TASK-393847trailer）。关联
a1846f18-21ad-4e33-b8df-5d53f239a2c5)