Skip to content

fix(dock): sync platform theme to tray plugin processes - #1688

Closed
MyLeeJiEun wants to merge 1 commit into
linuxdeepin:masterfrom
MyLeeJiEun:fork-from-master-0805/bug-372253
Closed

fix(dock): sync platform theme to tray plugin processes#1688
MyLeeJiEun wants to merge 1 commit into
linuxdeepin:masterfrom
MyLeeJiEun:fork-from-master-0805/bug-372253

Conversation

@MyLeeJiEun

@MyLeeJiEun MyLeeJiEun commented Aug 5, 2026

Copy link
Copy Markdown
Contributor
  1. Set DDE_TRAY_LOADER_REGISTER_PLATFORM_INTERFACE=1 in the tray loader plugin process env
  2. Tell the plugin it is hosted by dde-shell's dockplugin compositor, so it registers DQWaylandPlatformInterface before creating DPlatformTheme
  3. Ensure active color, theme, and font properties sync correctly to tray plugins

Log: Sync platform theme properties to tray plugin processes hosted by dde-shell.
Influence: Tray plugin visuals now follow the system theme correctly.

fix(dock): 同步平台主题到托盘插件进程

  1. 在托盘插件进程环境中设置 DDE_TRAY_LOADER_REGISTER_PLATFORM_INTERFACE=1
  2. 告知插件由 dde-shell 的 dockplugin 合成器托管,须在创建 DPlatformTheme 前注册 DQWaylandPlatformInterface
  3. 确保活动色、主题、字体等属性正确同步到托盘插件

Log: 同步平台主题属性到由 dde-shell 托管的托盘插件进程。
PMS: BUG-372253
Influence: 托盘插件外观将正确跟随系统主题。

Summary by Sourcery

Bug Fixes:

  • Ensure tray plugin processes hosted by the dock register the Wayland platform interface so active colors, themes, and fonts sync with the system.

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry @MyLeeJiEun, you have reached your weekly rate limit of 500000 diff characters.

Please try again later or upgrade to continue using Sourcery

@deepin-ci-robot

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: MyLeeJiEun

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deepin-ci-robot

Copy link
Copy Markdown

Hi @MyLeeJiEun. Thanks for your PR.

I'm waiting for a linuxdeepin member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sourcery-ai

sourcery-ai Bot commented Aug 5, 2026

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Sets a new environment variable for tray plugin processes so they can register the Wayland platform interface before creating DPlatformTheme, ensuring platform theme properties (active color, theme, fonts) sync correctly for dock-hosted tray plugins.

Sequence diagram for syncing platform theme to tray plugin processes

sequenceDiagram
    participant DockShell
    participant LoadTrayPlugins
    participant TrayPluginProcess
    participant DPlatformTheme

    DockShell->>LoadTrayPlugins: setProcessEnv
    LoadTrayPlugins->>TrayPluginProcess: start
    TrayPluginProcess->>TrayPluginProcess: main
    opt [DDE_TRAY_LOADER_REGISTER_PLATFORM_INTERFACE set]
        TrayPluginProcess->>DPlatformTheme: DPlatformTheme
    end
Loading

File-Level Changes

Change Details Files
Configure tray plugin subprocess environment to request registration of the platform interface before DPlatformTheme creation.
  • Extend setProcessEnv to insert DDE_TRAY_LOADER_REGISTER_PLATFORM_INTERFACE=1 into the tray plugin process environment
  • Document in comments that dock-hosted tray plugins must register DQWaylandPlatformInterface before creating DPlatformTheme to sync active color, theme, and font properties
panels/dock/loadtrayplugins.cpp

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@MyLeeJiEun
MyLeeJiEun force-pushed the fork-from-master-0805/bug-372253 branch from 3bca4fa to 638275a Compare August 5, 2026 07:15
1. Set DDE_TRAY_LOADER_REGISTER_PLATFORM_INTERFACE=1 in the tray loader plugin process env
2. Tell the plugin it is hosted by dde-shell's dockplugin compositor, so it registers DQWaylandPlatformInterface before creating DPlatformTheme
3. Ensure active color, theme, and font properties sync correctly to tray plugins

Log: Sync platform theme properties to tray plugin processes hosted by dde-shell.
Influence: Tray plugin visuals now follow the system theme correctly.

fix(dock): 同步平台主题到托盘插件进程

1. 在托盘插件进程环境中设置 DDE_TRAY_LOADER_REGISTER_PLATFORM_INTERFACE=1
2. 告知插件由 dde-shell 的 dockplugin 合成器托管,须在创建 DPlatformTheme 前注册 DQWaylandPlatformInterface
3. 确保活动色、主题、字体等属性正确同步到托盘插件

Log: 同步平台主题属性到由 dde-shell 托管的托盘插件进程。
PMS: BUG-372253
Influence: 托盘插件外观将正确跟随系统主题。
@MyLeeJiEun
MyLeeJiEun force-pushed the fork-from-master-0805/bug-372253 branch from 638275a to 51cb1ee Compare August 5, 2026 07:18
@MyLeeJiEun MyLeeJiEun closed this Aug 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants