fix(dock): sync platform theme to tray plugin processes - #1688
Conversation
There was a problem hiding this comment.
Sorry @MyLeeJiEun, you have reached your weekly rate limit of 500000 diff characters.
Please try again later or upgrade to continue using Sourcery
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: MyLeeJiEun The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @MyLeeJiEun. Thanks for your PR. I'm waiting for a linuxdeepin member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Reviewer's guide (collapsed on small PRs)Reviewer's GuideSets a new environment variable for tray plugin processes so they can register the Wayland platform interface before creating DPlatformTheme, ensuring platform theme properties (active color, theme, fonts) sync correctly for dock-hosted tray plugins. Sequence diagram for syncing platform theme to tray plugin processessequenceDiagram
participant DockShell
participant LoadTrayPlugins
participant TrayPluginProcess
participant DPlatformTheme
DockShell->>LoadTrayPlugins: setProcessEnv
LoadTrayPlugins->>TrayPluginProcess: start
TrayPluginProcess->>TrayPluginProcess: main
opt [DDE_TRAY_LOADER_REGISTER_PLATFORM_INTERFACE set]
TrayPluginProcess->>DPlatformTheme: DPlatformTheme
end
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
3bca4fa to
638275a
Compare
1. Set DDE_TRAY_LOADER_REGISTER_PLATFORM_INTERFACE=1 in the tray loader plugin process env 2. Tell the plugin it is hosted by dde-shell's dockplugin compositor, so it registers DQWaylandPlatformInterface before creating DPlatformTheme 3. Ensure active color, theme, and font properties sync correctly to tray plugins Log: Sync platform theme properties to tray plugin processes hosted by dde-shell. Influence: Tray plugin visuals now follow the system theme correctly. fix(dock): 同步平台主题到托盘插件进程 1. 在托盘插件进程环境中设置 DDE_TRAY_LOADER_REGISTER_PLATFORM_INTERFACE=1 2. 告知插件由 dde-shell 的 dockplugin 合成器托管,须在创建 DPlatformTheme 前注册 DQWaylandPlatformInterface 3. 确保活动色、主题、字体等属性正确同步到托盘插件 Log: 同步平台主题属性到由 dde-shell 托管的托盘插件进程。 PMS: BUG-372253 Influence: 托盘插件外观将正确跟随系统主题。
638275a to
51cb1ee
Compare
Log: Sync platform theme properties to tray plugin processes hosted by dde-shell.
Influence: Tray plugin visuals now follow the system theme correctly.
fix(dock): 同步平台主题到托盘插件进程
Log: 同步平台主题属性到由 dde-shell 托管的托盘插件进程。
PMS: BUG-372253
Influence: 托盘插件外观将正确跟随系统主题。
Summary by Sourcery
Bug Fixes: