smite-scenarios: log warning and tx_abort data on receive - #230
Merged
Conversation
morehouse
reviewed
Sep 3, 2026
morehouse
left a comment
morehouse
left a comment
Collaborator
There was a problem hiding this comment.
Did you run into a situation where this logging is helpful?
`warning` and `tx_abort` are, with `error`, the only wire messages that carry a human-readable `data` field. `recv_non_ping` already surfaces `error` through `ExecuteError::PeerError`, but a `warning` or `tx_abort` was handed back to the caller as-is, and callers only inspect the message type, so the text the target sent was lost. Log the channel id and data at warn level before returning the message. The bytes are printed with a lossy UTF-8 conversion rather than filtered to printable ASCII: targets are cooperating implementations under test, so readability is the only concern.
erickcestari
force-pushed
the
log-warning-message
branch
from
September 4, 2026 14:17
18bfd82 to
d19e499
Compare
Contributor
Author
Yes. I've noticed in the v1 funding flow and specially in the dual funding. There are a lot of these errors in the logs: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
warningandtx_abortare, witherror, the only wire messages that carry a human-readabledatafield.recv_non_pingalready surfaceserrorthroughExecuteError::PeerError, but awarningortx_abortwas handed back to the caller as-is, and callers only inspect the message type, so the text the target sent was lost.Log the channel id and data at warn level before returning the message. The bytes are printed with a lossy UTF-8 conversion rather than filtered to printable ASCII: targets are cooperating implementations under test, so readability is the only concern.