smitebot: validate --scenario against smite-scenarios/src/bin/ - #236
Merged
Merged
Conversation
Ashish-Kumar-Dash
force-pushed
the
scenario-validation
branch
from
September 8, 2026 06:48
d603ff1 to
fc475b9
Compare
morehouse
approved these changes
Sep 9, 2026
Ashish-Kumar-Dash
force-pushed
the
scenario-validation
branch
from
September 9, 2026 17:10
c5a827f to
65ce3a8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follows feedback on #104
Validates
--scenarioagainst the binary names insmite-scenarios/src/bin/before attempting a ~20 minute Docker build.Adds
pub fn check_scenario_exists(smite_dir, target, scenario)inconfig.rs. Called fromCampaignConfig::check_paths()(coversstartandconfig) and fromBuildCommand::execute()directly (coversbuild).Error names the missing path and lists valid scenarios when discoverable - unknown scenario 'nois' for target 'lnd': .../lnd_nois.rs does not exist; valid scenarios: encrypted_bytes, init, ir, noise