Add lines to graph and mini graph for "current time" on prior days - #644
Conversation
- Add vertical dotted orange lines to main graph for "this time" on prior days when scrolling back - Add vertical dotted orange lines to the mini graph for "this time" on prior days
- Removed unneeded empty lines
aug0211
changed the title
|
In what way are they tappable, what should happen if you tap them? |
|
In the mini graph, it's kind of basic. Not too fancy here. The line make it visible in the mini graph where "current time" was on prior days. Tap it on the mini graph and the main graph updates to show what was going on at that time (just like scrolling the mini graph currently does). Not much fanciness here, probably easiest to see and experience by deploying it. Edited the PR description - the dotted orange line in the main graph is just visual, tapping it does nothing. 
|
|
Thanks for the clarification and for updating the description. Tapping anywhere on the mini graph already positions the main graph at that time, lines or not, so that part is existing behavior rather than something this PR introduces. The lines themselves are a nice visual aid. Before proceeding I would like them behind a Graph settings toggle next to Show Midnight Lines, default off, like the other time markers. |
|
Good idea that makes sense. |
The vertical dotted orange lines marking the current time on prior days rendered unconditionally on both the main and mini graphs. Gate them on a new "Show Prior Day Time Lines" toggle in Graph Settings, defaulting to off, so they behave like Show Midnight Lines and the other time markers. The new storage key is unset for existing users, which reads as false, so the lines are hidden until explicitly enabled.
|
@bjorkert I took a crack at this and it's committed now. |
marionbarker
left a comment
marionbarker
left a comment
There was a problem hiding this comment.
Approve by test on iPhone 15 pro with 4 days of data.
Very nice.
4 participants
Uh oh!
There was an error while loading. Please reload this page.