Repository navigation
Ensure schemas are available during testing - #1605
Merged
Merged
Conversation
At least the 'subscription' test needs an up-to-date schema with respect to pre 2.x versions of liferea. Having the tests point at the systems version of schemas let the test fail if there is no up-to-date schema there. 'gnome.compile_schema' is "only useful when running the application locally for example during tests" [1]. Hence, let's point call that during the build and point the tests at it. [1] https://mesonbuild.com/Gnome-module.html#gnomecompile_schemas Disclaimer: I used GPT-6 Luna to help me figure out why the test were failing for me, how to fix it and find canonical documentation which is how I confirmed that the solution seems reasonable.
Owner
|
Thank you for the fix. I did not think about this. Also thanks for the AI transparency! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At least the 'subscription' test needs an up-to-date schema with respect to pre 2.x versions of liferea. Having the tests point at the systems version of schemas let the test fail if there is no up-to-date schema there. 'gnome.compile_schema' is "only useful when running the application locally for example during tests" [1]. Hence, let's point call that during the build and point the tests at it.
[1] https://mesonbuild.com/Gnome-module.html#gnomecompile_schemas
Disclaimer: I used GPT-6 Luna to help me figure out why the test were failing for me, how to fix it and find canonical documentation which is how I confirmed that the solution seems reasonable.