revert: stop emitting ATTRIBUTE_SETTER_CALLED diagnostic logs (#1405) - #1408
Conversation
PR SummaryLow Risk Overview Setter and identity paths again emit Placement dispatch again emits LoggingService uses three separate Reviewed by Cursor Bugbot for commit c400f53. Bugbot is set up for automated code reviews on this repo. Configure here. |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
|
🎉 This PR is included in version 3.2.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Summary
1542678b), which was accidentally squash-merged tomaininstead ofv3-development.selectPlacementsdiagnostic logging (ATTRIBUTE_SETTER_CALLED,SELECT_PLACEMENTS_DISPATCHED,diagnosticTiming.ts) onmainto the pre-fix(rokt): stop emitting ATTRIBUTE_SETTER_CALLED diagnostic logs #1405 state.Why revert instead of force-push
mainalready has the squash commit. A revert PR undoes the accidental merge without rewriting history.Follow-up
Keep #1398 moving on
v3-development. After that lands, re-apply the #1405 intent as a new PR onv3-development(keep preselect diagnostic helpers; do not cherry-pick this revert or the original #1405 commit onto that branch).Test plan
mainCI is greenv3-development