Skip to content

revert: stop emitting ATTRIBUTE_SETTER_CALLED diagnostic logs (#1405) - #1408

Merged
rmi22186 merged 1 commit into
mainfrom
revert/pr-1405
Sep 9, 2026
Merged

revert: stop emitting ATTRIBUTE_SETTER_CALLED diagnostic logs (#1405)#1408
rmi22186 merged 1 commit into
mainfrom
revert/pr-1405

Conversation

@rmi22186

@rmi22186 rmi22186 commented Sep 9, 2026

Copy link
Copy Markdown
Member

Summary

Why revert instead of force-push

main already has the squash commit. A revert PR undoes the accidental merge without rewriting history.

Follow-up

Keep #1398 moving on v3-development. After that lands, re-apply the #1405 intent as a new PR on v3-development (keep preselect diagnostic helpers; do not cherry-pick this revert or the original #1405 commit onto that branch).

Test plan

@rmi22186
rmi22186 requested a review from a team as a code owner September 9, 2026 19:44
@cursor

cursor Bot commented Sep 9, 2026

Copy link
Copy Markdown

PR Summary

Low Risk
Observability-only changes that log attribute names, not values; placement and attribute persistence behavior is unchanged aside from extra INFO log posts when logging is enabled.

Overview
Undoes #1405 on main by bringing back Rokt kit timing/diagnostic logs for attribute setters and selectPlacements, plus the diagnosticTiming helpers and tests that #1405 removed.

Setter and identity paths again emit ATTRIBUTE_SETTER_CALLED via logDiagnostic (source name + attribute keys only, including denylisted keys) on setUserAttribute, removeUserAttribute, and identity completion callbacks.

Placement dispatch again emits SELECT_PLACEMENTS_DISPATCHED via logPlacementDiagnostic with the merged placement attribute key list right before launcher.selectPlacements.

LoggingService uses three separate ReportingTransport instances so bursts of diagnostic entries cannot consume the same per-severity rate limit as operational log() traffic or each other.

Reviewed by Cursor Bugbot for commit c400f53. Bugbot is set up for automated code reviews on this repo. Configure here.

@coderabbitai

coderabbitai Bot commented Sep 9, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 4ac43178-cc01-4d87-8882-d235fe7a26f9

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@rmi22186
rmi22186 merged commit 9760503 into main Sep 9, 2026
64 of 66 checks passed
@mparticle-automation

Copy link
Copy Markdown
Collaborator

🎉 This PR is included in version 3.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants