Skip to content

fix: classify ZTOAD table as not extensible - #26

Merged
marianfoo merged 5 commits into
masterfrom
codex/fix-base-ddic-001
Aug 7, 2026
Merged

marianfoo merged 5 commits into
masterfrom
codex/fix-base-ddic-001

Conversation

@marianfoo

Copy link
Copy Markdown
Owner

What changed

  • declare transparent table ZTOAD as #NOT_EXTENSIBLE in its native-abapGit serialization
  • add a repository contract for the exact <EXCLASS>1</EXCLASS> representation
  • retain the current serializer's canonical MASTERLANG and field metadata output
  • document the reviewed A4H/NPL round trip, live evidence, rollback, and ARC-1 adapter findings

Why

The table had no enhancement category. SAP normalized it to #NOT_CLASSIFIED, NPL warned during offline installation, and native abapGit reported persistent metadata drift. ZTOAD is an internal persistence table with a deep STRING field and no supported append contract, so #NOT_EXTENSIBLE is the narrow compatible category on both supported releases.

Validation

  • red repository-contract replay recorded at fb60eca
  • native-abapGit candidate 4206a1a; src/ztoad.tabl.xml SHA-256 0a7b98b6c073e5062c56bfd314dc297ecd88dc0ea685bee643caabc9a76a1f40
  • local: npm ci, npm test, and git diff --check green; abaplint reports zero issues
  • A4H / SAP_BASIS 758: exact table active as #NOT_EXTENSIBLE, seven fields unchanged, no inactive ZTOAD part, 67/67 Unit, zero syntax errors plus two pre-existing POSIX warnings, recorded ATC baselines unchanged
  • NPL / SAP_BASIS 750: explicit table/report activation, table active as #NOT_EXTENSIBLE with seven fields unchanged, no inactive ZTOAD part, 67/67 Unit, zero syntax errors, complete DEFAULT ATC unchanged at 88 findings (3 P1, 4 P2, 81 P3)
  • browser/ST22 not applicable because runtime source, columns, screens, and transaction behavior are unchanged

Deployment note

The NPL offline import accidentally selected the archive's four repository objects rather than only TABL ZTOAD. The result was reviewed and retained: its program was exact current master, its transaction and authorization object were unchanged, and the later package-deletion proposal was not applied.

Rollback

Pull the reviewed master table serialization with native abapGit and explicitly activate TABL ZTOAD. No column conversion or data migration is involved.

@marianfoo

Copy link
Copy Markdown
Owner Author

Final reviewed head: 424a5172534ff365006ccfbb598f8d554156aba9.

  • GitHub Actions Quality run 31164553233: passed
  • abaplint: passed
  • abaplint observations: passed
  • post-green plan/implementation/evidence/CI audit completed
  • finished plan moved to docs/plans/finished/

No CI workflow change was required. The NPL direct table object-state adapter limitation is documented as BASE-TOOL-005 with independent activation/read/inactive-inventory evidence; it is not being reported as a successful object-state call.

@marianfoo
marianfoo marked this pull request as ready for review August 7, 2026 09:08
@marianfoo
marianfoo merged commit e5ae759 into master Aug 7, 2026
3 checks passed
@marianfoo
marianfoo deleted the codex/fix-base-ddic-001 branch August 7, 2026 09:08
@marianfoo

Copy link
Copy Markdown
Owner Author

Post-merge alignment completed for master e5ae759aa0ea8d6a2f5efb7a53fd0956ec5b3286:

  • native abapGit pulled full refs/heads/master on A4H
  • explicit TABL ZTOAD activation succeeded
  • active table is #NOT_EXTENSIBLE; active/inactive SHA-256 both 567b06bde9c933c8f1ceb802b3804d928a10f3e14d15c444e2725fd2b9b33441
  • active report syntax: zero errors, two known POSIX warnings
  • ABAP Unit: 67/67 passed
  • global inactive inventory: no ZTOAD part
  • post-merge master Quality run 31164614752: passed
  • Release Please run 31164614893: passed and updated PR chore(master): release 5.0.1 #23; its approved Quality run 31164638888 also passed

PR #23 remains open and unmerged as requested.

marianfoo pushed a commit that referenced this pull request Aug 7, 2026
🤖 I have created a release *beep* *boop*
---


## [5.0.1](5.0.0...5.0.1)
(2026-08-07)


### Bug Fixes

* bound temporary subroutine pools
([#32](#32))
([ef54657](ef54657))
* classify ZTOAD table as not extensible
([#26](#26))
([e5ae759](e5ae759))
* enforce bounded SELECT results
([#33](#33))
([b6acc14](b6acc14))
* execute queries safely in WebGUI
([#24](#24))
([5218476](5218476))
* execute UNION as one SQL set
([a5ad27c](a5ad27c))
* generate aggregate CASE result types
([#21](#21))
([d532b2e](d532b2e))
* isolate generated query failures
([#31](#31))
([b0b4d9f](b0b4d9f))
* parse top-level SQL clauses
([#28](#28))
([c5ca65b](c5ca65b))
* support ABAP SQL string functions
([#27](#27))
([0f056e8](0f056e8))
* verify complete native-abapGit installation
([#22](#22))
([2360fe4](2360fe4))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant