Repository navigation
fix: classify ZTOAD table as not extensible - #26
Merged
Merged
Conversation
Owner
Author
|
Final reviewed head:
No CI workflow change was required. The NPL direct table object-state adapter limitation is documented as |
Owner
Author
|
Post-merge alignment completed for master
PR #23 remains open and unmerged as requested. |
marianfoo
pushed a commit
that referenced
this pull request
Aug 7, 2026
🤖 I have created a release *beep* *boop* --- ## [5.0.1](5.0.0...5.0.1) (2026-08-07) ### Bug Fixes * bound temporary subroutine pools ([#32](#32)) ([ef54657](ef54657)) * classify ZTOAD table as not extensible ([#26](#26)) ([e5ae759](e5ae759)) * enforce bounded SELECT results ([#33](#33)) ([b6acc14](b6acc14)) * execute queries safely in WebGUI ([#24](#24)) ([5218476](5218476)) * execute UNION as one SQL set ([a5ad27c](a5ad27c)) * generate aggregate CASE result types ([#21](#21)) ([d532b2e](d532b2e)) * isolate generated query failures ([#31](#31)) ([b0b4d9f](b0b4d9f)) * parse top-level SQL clauses ([#28](#28)) ([c5ca65b](c5ca65b)) * support ABAP SQL string functions ([#27](#27)) ([0f056e8](0f056e8)) * verify complete native-abapGit installation ([#22](#22)) ([2360fe4](2360fe4)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
ZTOADas#NOT_EXTENSIBLEin its native-abapGit serialization<EXCLASS>1</EXCLASS>representationMASTERLANGand field metadata outputWhy
The table had no enhancement category. SAP normalized it to
#NOT_CLASSIFIED, NPL warned during offline installation, and native abapGit reported persistent metadata drift.ZTOADis an internal persistence table with a deepSTRINGfield and no supported append contract, so#NOT_EXTENSIBLEis the narrow compatible category on both supported releases.Validation
fb60eca4206a1a;src/ztoad.tabl.xmlSHA-2560a7b98b6c073e5062c56bfd314dc297ecd88dc0ea685bee643caabc9a76a1f40npm ci,npm test, andgit diff --checkgreen; abaplint reports zero issues#NOT_EXTENSIBLE, seven fields unchanged, no inactive ZTOAD part, 67/67 Unit, zero syntax errors plus two pre-existing POSIX warnings, recorded ATC baselines unchanged#NOT_EXTENSIBLEwith seven fields unchanged, no inactive ZTOAD part, 67/67 Unit, zero syntax errors, completeDEFAULTATC unchanged at 88 findings (3 P1, 4 P2, 81 P3)Deployment note
The NPL offline import accidentally selected the archive's four repository objects rather than only
TABL ZTOAD. The result was reviewed and retained: its program was exact currentmaster, its transaction and authorization object were unchanged, and the later package-deletion proposal was not applied.Rollback
Pull the reviewed
mastertable serialization with native abapGit and explicitly activateTABL ZTOAD. No column conversion or data migration is involved.