Update phpunit/phpunit from 8.3.4 to 8.5.46 - #185
violinist-bot wants to merge 1 commit into
Conversation
WalkthroughUpdated the development dependency phpunit/phpunit from version 8.3.4 to 8.5.46 in composer.json. No other files or declarations were modified. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests
Tip 👮 Agentic pre-merge checks are now available in preview!Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.
Please see the documentation for more information. Example: reviews:
pre_merge_checks:
custom_checks:
- name: "Undocumented Breaking Changes"
mode: "warning"
instructions: |
Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).Please share your feedback with us on this Discord post. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
composer.json (2)
23-23: Optional: relax pin to allow future 8.5 patch fixes.If you’re okay with non-breaking patches, prefer a caret within the same major:
- "phpunit/phpunit": "8.5.46", + "phpunit/phpunit": "^8.5.46",
1-31: Optional: declare a PHP platform/require to align dev tools with runtime.You currently don’t declare
"php"in"require". Consider adding one to document supported runtimes and avoid accidental resolver drift locally/CI (choose the correct constraint for the library, not for PHPUnit):Example:
"require": { + "php": "^7.2 || ^8.0", "guzzlehttp/guzzle": "6.3.*", "symfony/dotenv": "4.3.*", "ext-json": "*" },Only do this if it matches your library’s actual support policy.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
composer.lockis excluded by!**/*.lock
📒 Files selected for processing (1)
composer.json(1 hunks)
🔇 Additional comments (3)
composer.json (3)
17-25: CI matrix is compatible with PHPUnit 8.5 (requires PHP ≥ 7.2).
.travis.yml lists:
php:
- '7.2'
- '7.3'
No other CI configs found; no PHP ≤ 7.1 in the matrix.
17-25: Paratest 3.x compatibility with PHPUnit 8.5.46 — OKParatest 3.* targets PHPUnit 8 (mapping 8.* → 3.*), so the current "brianium/paratest": "3.0" in composer.json is compatible with phpunit 8.5.46. Use "brianium/paratest:^3.0" if you want composer to accept all 3.x releases.
23-23: Upgrade safe — no Prophecy usage found; add phpspec/prophecy-phpunit only if tests use Prophecy.composer.lock contains "phpspec/prophecy" as a transitive dependency (composer.lock:968). Repository search for "prophesize" and "ProphecyTrait" returned no matches. If your tests use Prophecy, add to require-dev: "phpspec/prophecy-phpunit": "^2.0".
If you have a high test coverage index, and your tests for this pull request are passing, it should be both safe and recommended to merge this update.
Updated packages
Some times an update also needs new or updated dependencies to be installed. Even if this branch is for updating one dependency, it might contain other installs or updates. All of the updates in this branch can be found here:
Working with this branch
If you find you need to update the codebase to be able to merge this branch (for example update some tests or rebuild some assets), please note that violinist will force push to this branch to keep it up to date. This means you should not work on this branch directly, since you might lose your work. Read more about branches created by violinist.io here.
This is an automated pull request from Violinist: Continuously and automatically monitor and update your composer dependencies. Have ideas on how to improve this message? All violinist messages are open-source, and can be improved here.
Summary by CodeRabbit