Repository navigation
FIX: Harden cross-platform release validation - #38
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The changes are straightforward hardening improvements and appear correct, with only minor error-message clarity suggestions outstanding.
Pull request overview
This PR hardens the release pipeline by ensuring cross-platform release test jobs run against the same validated commit as the release tag, and by strengthening pre-publish validation (including a native CLI build) while reducing flakiness in Windows installer tests.
Changes:
- Add a post-checkout verification step in the release test matrix to ensure
HEADmatches the commit SHA validated from the tag. - Add an explicit
go build -buildvcs=false -trimpath ./cmd/claistep in the release test matrix before publishing. - Update the Windows installer test harness to wait until the fixture server port file contains a complete numeric port.
File summaries
| File | Description |
|---|---|
| test/install-release.ps1 | Improves fixture-server port readiness handling to wait for a fully written numeric port value. |
| .github/workflows/release.yml | Adds commit immutability verification in the OS matrix and adds an explicit build step prior to publishing. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
go vet ./...go test -race ./...go build -buildvcs=false -trimpath ./cmd/claibats test(18 tests)