Repository navigation
Fix live-state questions being reduced to command descriptions - #40
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Removing fallback routing makes the documented question_query setting unreachable without System One.
Get a fresh assessment by requesting another Copilot review.
Review effort: Lite
Findings: 1
What changed in this PR
Updates question handling so live-state requests execute commands while general questions can be answered directly.
Changes:
- Removes punctuation-based question routing.
- Updates LLM and System One intent guidance.
- Adds documentation and regression tests.
| File | Description |
|---|---|
| README.md | Documents semantic routing behavior. |
| internal/systemone/client.go | Clarifies live-state execution criteria. |
| internal/app/prompts.go | Updates execution guidance and examples. |
| internal/app/app.go | Removes question-mark fallback routing. |
| internal/app/app_test.go | Adds routing and result-interpretation tests. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Problem
clai what is the time?could display only "shows the current system date and time", while the same request without?randateand interpreted its output. The fallback router treated any question mark as answer-only mode, which discarded the generated command.Changes
Validation
make checkpassed (Go vet/tests and all 18 Bats tests).