Repository navigation
FIX: Contain post location labels on narrow screens - #183
Merged
Merged
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
The new system spec/page-object bounds logic is currently too driver-dependent (native bounding box shape/keys), which risks brittle or failing CI runs.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR addresses an overflow issue where long post location labels can collide with adjacent post metadata on very narrow screens by allowing the label to shrink and wrap within its flex row, and adds a system spec to assert containment behavior next to the avatar/flag.
Changes:
- Adjusts
.user-locationstyling to allow flex shrink and wrapping on narrow screens. - Adds a new system spec asserting post location/flag containment at a very small viewport width.
- Introduces a
PostLocationsystem page object for querying location-related DOM bounds; bumps plugin version.
File summaries
| File | Description |
|---|---|
| spec/system/user_location_spec.rb | Adds a narrow-screen system test verifying location/flag containment using element bounds. |
| spec/system/page_objects/post_location.rb | New page object to locate post location elements and compute their bounds. |
| assets/stylesheets/common/locations-user.scss | Updates flex item constraints (min-width: 0) and wrapping to prevent overflow/collision. |
| plugin.rb | Bumps plugin version to reflect the change. |
Review details
- Files reviewed: 4/4 changed files
- Comments generated: 2
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, long post location labels could overflow their flex row and collide with adjacent post metadata on very narrow screens.
This change allows the label to shrink and wrap within the available space, with system coverage for avatar and flag containment.