Skip to content

FIX: Contain post location labels on narrow screens - #183

Merged
merefield merged 3 commits into
mainfrom
fix/narrow-post-location-overflow
Aug 27, 2026
Merged

merefield merged 3 commits into
mainfrom
fix/narrow-post-location-overflow

Conversation

@merefield

Copy link
Copy Markdown
Owner

Previously, long post location labels could overflow their flex row and collide with adjacent post metadata on very narrow screens.

This change allows the label to shrink and wrap within the available space, with system coverage for avatar and flag containment.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The new system spec/page-object bounds logic is currently too driver-dependent (native bounding box shape/keys), which risks brittle or failing CI runs.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

This PR addresses an overflow issue where long post location labels can collide with adjacent post metadata on very narrow screens by allowing the label to shrink and wrap within its flex row, and adds a system spec to assert containment behavior next to the avatar/flag.

Changes:

  • Adjusts .user-location styling to allow flex shrink and wrapping on narrow screens.
  • Adds a new system spec asserting post location/flag containment at a very small viewport width.
  • Introduces a PostLocation system page object for querying location-related DOM bounds; bumps plugin version.
File summaries
File Description
spec/system/user_location_spec.rb Adds a narrow-screen system test verifying location/flag containment using element bounds.
spec/system/page_objects/post_location.rb New page object to locate post location elements and compute their bounds.
assets/stylesheets/common/locations-user.scss Updates flex item constraints (min-width: 0) and wrapping to prevent overflow/collision.
plugin.rb Bumps plugin version to reflect the change.
Review details
  • Files reviewed: 4/4 changed files
  • Comments generated: 2
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread spec/system/page_objects/post_location.rb
Comment thread spec/system/user_location_spec.rb Outdated
@merefield
merefield merged commit c0a059b into main Aug 27, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants