Repository navigation
FIX: Align mobile PM locations with usernames and titles - #186
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mobile personal messages from users with titles can still show the location to the left of the username after #185. The avatar's width plus its float margin can exceed the metadata's nominal 50px inset, so copying that inset does not guarantee alignment.
Wrap the metadata and location in one flow-root container only below 40rem on personal-message pages with a rendered user title. The container clears the avatar horizontally, and both rows share its left edge. Use display: contents for the wrapper in other scenarios. Bump the plugin version to 7.3.16.
Validation: 96 reduced Chromium layout checks across viewport sizes, avatar sizes, font sizes, public/PM, and title/no-title combinations. These reproduced the previous misalignment, verified identical left coordinates for the location, username, and title in the targeted case, and verified unchanged coordinates in other cases. Prettier, Stylelint, ESLint, Ruby syntax, and git diff checks passed. Full Discourse system tests were not run.