Ignore legacy hook related attributes

[Berdir]

Feature request

Drupal maintains several hook related attributes for BC management. LegacyHook, LegacyRequirementsHook and LegacyModuleImplementsAlter. They were added in different minor versions and D12 is now removing the first again.

Managing this in phpstan is tedious because depending on the core version, either either complains that it doesn't exist (yet or not anymore) or it complains that ignoring said problem is a problem because it does exist.

Would it be possible to just completely skip these attributes and ignore them and whether or not they exist or not?

[mglaman]

I don't know if there is a great fix to this beyond the extension allowing those to be ignored: #967

@Berdir thoughts? I kind of hate it. Maybe it should go into the default phpstan.neon the D.o GitLab CI templates provide?

[Berdir]

Missed your reply. I don't really have opinions on this, I have little to no experience on customizing this. I can just say that we continue to get comments about people who are confused about these messages and try to fix them as it clutters not only CI reports but also upgrade_status, see https://www.drupal.org/project/drupal/issues/3482464#comment-16656083 for example.

[Berdir]

Nice. Didn't test yet, note that part of that commit message is wrong. LegacyModuleImplementsAlter is the one being removed.

Also, there's a new one, for the removal of .theme and .module files (to be committed soon, same attribute): https://www.drupal.org/node/3581222, maybe that could be added here in the same style?