Teams/User Groups - #64
Merged
Merged
Conversation
hujalex
marked this pull request as ready for review
August 25, 2026 05:44
hujalex
requested review from
HangYeung1 and
pradhamk
and removed request for
HangYeung1
August 27, 2026 21:07
pradhamk
requested changes
Aug 30, 2026
pradhamk
left a comment
Member
There was a problem hiding this comment.
One thing that I think is worth considering is filtering team names? However, since filtering out "bad" team names is effectively impossible here, maybe add a notice when the user is creating a team name that makes it clear than inappropriate team names will result in the entire hacker team having their acceptances revoked and that the tech team is actively checking team names.
pradhamk
reviewed
Aug 30, 2026
HangYeung1
force-pushed
the
user-groups
branch
from
September 10, 2026 21:37
d7d065e to
6c01e08
Compare
Contributor
|
OH FUCK I DID NOT SANDBOX MY AGENT CORRECTLY |
Schema definitions stay on this branch; the SQL migration will be regenerated separately before deploy. Co-authored-by: Cursor <cursoragent@cursor.com>
HangYeung1
force-pushed
the
user-groups
branch
from
September 10, 2026 21:55
6c01e08 to
4a41f4f
Compare
Regenerated with a current timestamp so production will apply it after merge. Co-authored-by: Cursor <cursoragent@cursor.com>
Surfaces reviewer feedback that inappropriate names may revoke acceptances for the whole team. Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
|
Addressed the review feedback:
|
Require accepted hackers for team mutations, dedupe pending invites at app and DB layers, and sanitize invite email display names. Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
|
Addressed Bugbot + security review findings:
|
Redirect non-accepted hackers away from /dashboard/team and count pending invitations against open team slots. Co-authored-by: Cursor <cursoragent@cursor.com>
The auth container cannot reach Mailpit on 127.0.0.1:54325 from inside Docker, which caused OTP sends to fail with connection refused. Co-authored-by: Cursor <cursoragent@cursor.com>
Keeps the warning on-brand with the console UI instead of a native dialog. Co-authored-by: Cursor <cursoragent@cursor.com>
Render the template asynchronously with React Email while matching OTP colors and layout. Co-authored-by: Cursor <cursoragent@cursor.com>
Replace the two branch migrations with one regenerated user_groups migration so deploy order stays correct after rebasing on main. Co-authored-by: Cursor <cursoragent@cursor.com>
The Google Fonts head links match otp.html and are rendered as email HTML, not Next.js pages. Co-authored-by: Cursor <cursoragent@cursor.com>
Keep team formation off until launch by toggling TEAM_PAGE_ENABLED in lib/features.ts. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.