Skip to content

organize all public env build args #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
HangYeung1 wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

organize all public env build args #75

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 16 additions & 6 deletions .github/workflows/cd.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,19 +58,29 @@ jobs:
id: login-ecr
uses: aws-actions/amazon-ecr-login@v2

- name: Prepare build env
id: build-env
env:
NEXT_PUBLIC_SUPABASE_URL: ${{ secrets.NEXT_PUBLIC_SUPABASE_URL }}
NEXT_PUBLIC_SUPABASE_PUBLISHABLE_KEY: ${{ secrets.NEXT_PUBLIC_SUPABASE_PUBLISHABLE_KEY }}
NEXT_PUBLIC_LOGIN_TURNSTILE_SITE_KEY: ${{ secrets.NEXT_PUBLIC_LOGIN_TURNSTILE_SITE_KEY }}
NEXT_PUBLIC_POSTHOG_PROJECT_TOKEN: ${{ secrets.NEXT_PUBLIC_POSTHOG_PROJECT_TOKEN }}
NEXT_PUBLIC_POSTHOG_HOST: ${{ secrets.NEXT_PUBLIC_POSTHOG_HOST }}
run: |
{
echo "env_b64<<EOF"
env | grep '^NEXT_PUBLIC_' | base64 -w0
echo "EOF"
} >> "$GITHUB_OUTPUT"

- name: Build image
id: build
uses: redhat-actions/buildah-build@v2
with:
image: ${{ env.CONTAINER_NAME }}
tags: latest ${{ github.sha }}
containerfiles: ./Dockerfile
build-args: |
NEXT_PUBLIC_SUPABASE_URL=${{ secrets.NEXT_PUBLIC_SUPABASE_URL }}
NEXT_PUBLIC_SUPABASE_PUBLISHABLE_KEY=${{ secrets.NEXT_PUBLIC_SUPABASE_PUBLISHABLE_KEY }}
NEXT_PUBLIC_LOGIN_TURNSTILE_SITE_KEY=${{ secrets.NEXT_PUBLIC_LOGIN_TURNSTILE_SITE_KEY }}
NEXT_PUBLIC_POSTHOG_PROJECT_TOKEN=${{ secrets.NEXT_PUBLIC_POSTHOG_PROJECT_TOKEN }}
NEXT_PUBLIC_POSTHOG_HOST=${{ secrets.NEXT_PUBLIC_POSTHOG_HOST }}
build-args: BUILD_ENV_B64=${{ steps.build-env.outputs.env_b64 }}

- name: Push image to ECR
id: push
Expand Down
15 changes: 4 additions & 11 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,16 +48,7 @@ COPY . .

ENV NODE_ENV=production

ARG NEXT_PUBLIC_SUPABASE_URL
ARG NEXT_PUBLIC_SUPABASE_PUBLISHABLE_KEY
ARG NEXT_PUBLIC_LOGIN_TURNSTILE_SITE_KEY
ARG NEXT_PUBLIC_POSTHOG_PROJECT_TOKEN
ARG NEXT_PUBLIC_POSTHOG_HOST
ENV NEXT_PUBLIC_SUPABASE_URL=$NEXT_PUBLIC_SUPABASE_URL
ENV NEXT_PUBLIC_SUPABASE_PUBLISHABLE_KEY=$NEXT_PUBLIC_SUPABASE_PUBLISHABLE_KEY
ENV NEXT_PUBLIC_LOGIN_TURNSTILE_SITE_KEY=$NEXT_PUBLIC_LOGIN_TURNSTILE_SITE_KEY
ENV NEXT_PUBLIC_POSTHOG_PROJECT_TOKEN=$NEXT_PUBLIC_POSTHOG_PROJECT_TOKEN
ENV NEXT_PUBLIC_POSTHOG_HOST=$NEXT_PUBLIC_POSTHOG_HOST
ARG BUILD_ENV_B64

# Next.js collects completely anonymous telemetry data about general usage.
# Learn more here: https://nextjs.org/telemetry
Expand All @@ -70,7 +61,9 @@ ENV NEXT_PUBLIC_POSTHOG_HOST=$NEXT_PUBLIC_POSTHOG_HOST
# This caches the .next/cache directory across builds, but it also prevents
# .next/cache/fetch-cache from being included in the final image, meaning
# cached fetch responses from the build won't be available at runtime.
RUN if [ -f package-lock.json ]; then \
RUN BUILD_ENV="$(printf '%s' "$BUILD_ENV_B64" | base64 -d)" \
&& printf '%s\n' "$BUILD_ENV" > .env.production.local \
&& if [ -f package-lock.json ]; then \
npm run build; \
elif [ -f yarn.lock ]; then \
corepack enable yarn && yarn build; \
Expand Down
20 changes: 0 additions & 20 deletions task-definition.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,14 +17,6 @@
"mountPoints": [],
"volumesFrom": [],
"secrets": [
{
"name": "NEXT_PUBLIC_SUPABASE_PUBLISHABLE_KEY",
"valueFrom": "arn:aws:ssm:us-east-2:AWS_ACCOUNT_ID:parameter/mhacks-secrets/NEXT_PUBLIC_SUPABASE_PUBLISHABLE_KEY"
},
{
"name": "NEXT_PUBLIC_SUPABASE_URL",
"valueFrom": "arn:aws:ssm:us-east-2:AWS_ACCOUNT_ID:parameter/mhacks-secrets/NEXT_PUBLIC_SUPABASE_URL"
},
{
"name": "RESUMES_BUCKET",
"valueFrom": "arn:aws:ssm:us-east-2:AWS_ACCOUNT_ID:parameter/mhacks-secrets/RESUMES_BUCKET"
Expand Down Expand Up @@ -64,18 +56,6 @@
{
"name": "LOGIN_TURNSTILE_SECRET_KEY",
"valueFrom": "arn:aws:ssm:us-east-2:AWS_ACCOUNT_ID:parameter/mhacks-secrets/LOGIN_TURNSTILE_SECRET_KEY"
},
{
"name": "NEXT_PUBLIC_LOGIN_TURNSTILE_SITE_KEY",
"valueFrom": "arn:aws:ssm:us-east-2:AWS_ACCOUNT_ID:parameter/mhacks-secrets/NEXT_PUBLIC_LOGIN_TURNSTILE_SITE_KEY"
},
{
"name": "NEXT_PUBLIC_POSTHOG_PROJECT_TOKEN",
"valueFrom": "arn:aws:ssm:us-east-2:AWS_ACCOUNT_ID:parameter/mhacks-secrets/NEXT_PUBLIC_POSTHOG_PROJECT_TOKEN"
},
{
"name": "NEXT_PUBLIC_POSTHOG_HOST",
"valueFrom": "arn:aws:ssm:us-east-2:AWS_ACCOUNT_ID:parameter/mhacks-secrets/NEXT_PUBLIC_POSTHOG_HOST"
}
],
"logConfiguration": {
Expand Down
Loading