fix: clean up auth when deleting named contexts#436
Conversation
bcbd734 to
46a68ba
Compare
|
hey @Harsh4902 , would love your feedback here |
|
@cotishq Please resolve the conflicts. |
|
The current delete path uses the context name for user cleanup, which is wrong for named contexts where One thing to double-check before merge: are If shared references are not a supported case, LGTM. @Harsh4902 |
Signed-off-by: cotishq <tanishqp101204@gmail.com>
46a68ba to
252197d
Compare
|
yeah you are right, since microcks login supports the --name flag, users can define multiple named contexts pointing to the same server or user. so if one is deleted, deleting the server, user or auth config unconditionally would indeed break the remaining contexts that reference them. i think we should check if any other contexts still reference the removed contexts user or server before deleting them. what's your opinion should i update the PR to add references checking ? |
Description
userandservervalues instead of the context name.context --deletefor a named context wherecontexts[].namediffers fromcontexts[].user.Screenshot
Related issue(s)
Fixes #427