Skip to content

CI: restore generated SLN or SLNX on VS 2026 runners - #118

Merged
vdwtanner merged 1 commit into
masterfrom
user/tvandewalle/fix-github-actions-slnx-restore
Sep 4, 2026
Merged

CI: restore generated SLN or SLNX on VS 2026 runners#118
vdwtanner merged 1 commit into
masterfrom
user/tvandewalle/fix-github-actions-slnx-restore

Conversation

@vdwtanner

Copy link
Copy Markdown
Contributor

Problem

windows-latest now resolves to the Windows Server 2025 / Visual Studio 2026 runner. CMake therefore selects the Visual Studio 18 2026 generator, which emits a .slnx solution. The workflow hard-codes a generated .sln path, so NuGet restore fails with Input file does not exist immediately after successful CMake generation.

This is independent of the open Dependabot action-update PR: a separate run using the previous actions/checkout and NuGet/setup-nuget versions fails identically.

Fix

Discover the single generated .sln or .slnx file and restore that path. The check fails loudly if CMake generates zero or multiple solutions. Explicit nuget.exe restore is retained for native packages.config compatibility.

Validation

  • Compared the last green runner (windows-2025, Visual Studio 17 2022, .sln) with the current failure (windows-2025-vs2026, Visual Studio 18 2026, missing hard-coded .sln).
  • Verified the same failure signature across D3D12TranslationLayer, D3D11On12, and D3D9On12.
  • git diff --check passes; this PR changes only .github/workflows/prBuild.yml.
  • GitHub Actions is the runtime validation for the generated .slnx path.

Comment thread .github/workflows/prBuild.yml Fixed
@vdwtanner
vdwtanner force-pushed the user/tvandewalle/fix-github-actions-slnx-restore branch from dae1e48 to 03220c3 Compare September 4, 2026 20:41
@vdwtanner
vdwtanner merged commit b68ebbc into master Sep 4, 2026
5 checks passed
@vdwtanner
vdwtanner deleted the user/tvandewalle/fix-github-actions-slnx-restore branch September 4, 2026 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants