Fix issue 5566: encoding='utf-8' for playwright_controller - #8010
Open
wasim-builds wants to merge 2 commits into
Open
Fix issue 5566: encoding='utf-8' for playwright_controller#8010wasim-builds wants to merge 2 commits into
wasim-builds wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5566
Problem
playwright_controller.pyopens files without explicitly specifying UTF-8 encoding. On systems where the default encoding is not UTF-8 (e.g., Windows with GBK/CP1252), this causesUnicodeDecodeErrororUnicodeEncodeErrorwhen reading/writing web page content containing non-ASCII characters.Fix
Add
encoding='utf-8'to the file open call inplaywright_controller.py. This ensures consistent behavior across all platforms regardless of system locale.Scope
Single-line change in
python/packages/autogen-ext/src/autogen_ext/agents/web_surfer/playwright_controller.py.Verification
The web surfer agent can now scrape and interact with pages containing non-ASCII content (Chinese, emoji, accented characters) on Windows, Linux, and macOS without encoding errors.