[draft] do not review - #5442
Draft
Anurag Saxena (saxena-anurag) wants to merge 19 commits into
Draft
Conversation
Instead of preventing cleanup on worker threads (which left leftover program state), use a static CRITICAL_SECTION to serialize link cleanup across all threads. This prevents races where one thread detaches links while another is attaching them, while still ensuring all threads clean up their state. - Add _cleanup_lock static mutex to _native_module_helper - Initialize/destroy lock via static helper object - Wrap bpf_link cleanup sequence in EnterCriticalSection/LeaveCriticalSection This fixes API test failures that were caused by leftover programs from previous test runs polluting the system state.
…d cleanup" This reverts commit 51a2f64.
…ebpf-for-windows into user/anusa/issue_5238
Contributor
Contributor
Contributor
Contributor
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Describe the purpose of and changes within this Pull Request.
Please reference an issue with a keyword such as Fixes #abc, Closes #xyz, etc., so the work can be tracked.
Testing
Do any existing tests cover this change? Are new tests needed?
If new tests were added:
Documentation
Is there any documentation impact for this change?
Installation
Is there any installer impact for this change?