Repository navigation
Preserve currency prefixes when converting XLSX files - #2874
Open
Aaditya Shasidhar Kolla (An-A-The) wants to merge 3 commits into
Open
Aaditya Shasidhar Kolla (An-A-The) wants to merge 3 commits into
Aaditya Shasidhar Kolla (An-A-The) wants to merge 3 commits into
Conversation
Author
@microsoft-github-policy-service agree |
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #53.
Currently, XLSX conversion loses currency symbols because pandas reads cell values but discards Excel's number-format metadata.
This change uses openpyxl to extract currency prefixes from cell formats and preserves them in the generated Markdown output.
It also handles locale-specific currency formats and duplicate column headers, ensuring that each cell receives the correct currency prefix.
Before / After
Scope: This preserves currency prefixes only; it does not reproduce Excel's complete number formatting (such as decimal places and thousands separators).
Tests: Added unit and integration tests covering currency formats, percentages, locale markers, and duplicate column headers.
Test results: