windows-reactor: Update to Windows App SDK 2.4.0 - #4835
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the windows-reactor toolchain and runtime staging to Windows App SDK 2.4.0, aligning the
pinned generator inputs, runtime deployment helper, and CI host runtime installation.
Changes:
- Bump the Windows App SDK pin to
2.4.0intool_reactorand documentation, and update CI to
install the matching runtime. - Update WinAppSDK bootstrap/version constants in the reactor bindings (and selftest bindings) to
match the 2.4.0 release. - Remove the framework-dependent
resources.pristaging workaround fromwindows-reactor-setup.
Reviewed changes
Copilot reviewed 8 out of 38 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| docs/dependencies.md | Updates documented Windows App SDK pins to 2.4.0 (docs for dependency ownership/validation). |
| crates/tools/reactor/src/main.rs | Bumps WINDOWS_APP_SDK_VERSION to 2.4.0 and keeps pin-guard logic aligned with CI/runtime. |
| crates/tools/reactor/src/extras.rdl | Updates WinAppSDK version constants used by generated bindings. |
| crates/tests/libs/reactor_selftest/src/bindings.rs | Regenerated bindings reflecting updated WinAppSDK constants. |
| crates/libs/reactor/src/bindings.rs | Regenerated bindings reflecting updated WinAppSDK constants used by bootstrap. |
| crates/libs/reactor-setup/src/lib.rs | Bumps runtime pin and removes framework-dependent resources.pri staging. |
| crates/libs/reactor-setup/assets/app.manifest | Updates the manifest header’s source-package references for the refreshed activation manifest. |
| .github/workflows/reactor.yml | Updates the Windows App Runtime installer URL to 2.4.0 for CI. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Kenny Kerr (kennykerr)
approved these changes
Aug 14, 2026
Co-authored-by: riverar <475132+riverar@users.noreply.github.com>
QAQTam (QAQTam)
added a commit
to QAQTam/qaq-winui-reactor
that referenced
this pull request
Aug 16, 2026
Keep fork patch: VisualTreeHelper walk (scroll_to_bottom dependency).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #4546, #4662
Upgrades Windows App SDK and related dependencies to 2.4.0 across the windows-reactor codebase. Removes the workaround that staged a PRI file next to the executable for framework-dependent apps, as it is no longer needed.
Just a reminder: Latest runtimes can be downloaded from https://learn.microsoft.com/windows/apps/windows-app-sdk/downloads#windows-app-sdk-20