You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Fixing 3 small accessibility bugs. The first two are instances where navigating and selecting the copy button using the keyboard lost focus and restarted keyboard navigation flow. The last is an issue where tab navigation was trapped by the monaco editor because it was unnecessarily an editable version of the monaco editor. lastly, set aria-labels to dropdown menu to remove accessibility insights flag.
How to test changes
testing old behaviour currently observed from prod
copy button
pressing the copy button with keyboard copies, but loses focus of the icon. can be observed from the response headers and adaptive cards>json tabs in query response section of the page.
monaco editor
editable monaco editor:
aria labels
inspect element on the drop downs in query runner:
run accessibility insights fast pass on graph explorer:
new observed behavior
copy button
copy remains focused
monaco editor
the editor is now read only. tab navigation should be fully possible on response headers tab both tabbing forward and shift-tabbing backward. can still copy and select text as in other areas where there are read-only editors (in responses)
aria labels
inspect element on drop downs in the query runner:
running fast pass from accessibility insights will not flag this issue any longer.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixing 3 small accessibility bugs. The first two are instances where navigating and selecting the copy button using the keyboard lost focus and restarted keyboard navigation flow. The last is an issue where tab navigation was trapped by the monaco editor because it was unnecessarily an editable version of the monaco editor. lastly, set aria-labels to dropdown menu to remove accessibility insights flag.
How to test changes
testing old behaviour currently observed from prod
copy button
pressing the copy button with keyboard copies, but loses focus of the icon. can be observed from the response headers and adaptive cards>json tabs in query response section of the page.
monaco editor
editable monaco editor:
aria labels
inspect element on the drop downs in query runner:
run accessibility insights fast pass on graph explorer:
new observed behavior
copy button
copy remains focused
monaco editor
the editor is now read only. tab navigation should be fully possible on response headers tab both tabbing forward and shift-tabbing backward. can still copy and select text as in other areas where there are read-only editors (in responses)
aria labels
inspect element on drop downs in the query runner:
running fast pass from accessibility insights will not flag this issue any longer.