Skip to content

fix: keyboard nav returns to feedback button after closing or submitting feedback form - #4088

Merged
Claudio Castillo (claudio-codebase) merged 8 commits into
devfrom
fix/feedback_keyboard_nav
Oct 16, 2026
Merged

Claudio Castillo (claudio-codebase) merged 8 commits into
devfrom
fix/feedback_keyboard_nav

Conversation

@claudio-codebase

@claudio-codebase Claudio Castillo (claudio-codebase) commented Oct 2, 2026 •

Copy link
Copy Markdown
Contributor

Addressing two bugs. The first is that users who navigate with keyboard are directed back to the button that opens the feedback dialog after closing or submitting their feedback. The second is that users who use keyboard navigation will be directed to the first element of the survey, which is the close button, as opposed to the first input for survey response.

current behavior

using keyboard navigation and closing the dialog loses place in keyboard navigation. the first selected option in the survey is the rating options.

Recording.2026-10-05.144410.mp4

new behavior

keep place in keyboard navigation, in the case of either closing or submitting the feedback. first option that is selected is now the x to close the dialog as well.

Recording.2026-10-05.145350.mp4

Claudio Castillo added 2 commits October 2, 2026 15:33
…ack when closing the form using esc, selecting x, or submitting the form
@github-actions

github-actions Bot commented Oct 2, 2026

Copy link
Copy Markdown
Contributor

Azure Static Web Apps: Your stage site is ready! Visit it here: https://calm-wave-0c4fb390f-4088.eastus2.4.azurestaticapps.net

1 similar comment
@github-actions

github-actions Bot commented Oct 2, 2026

Copy link
Copy Markdown
Contributor

Azure Static Web Apps: Your stage site is ready! Visit it here: https://calm-wave-0c4fb390f-4088.eastus2.4.azurestaticapps.net

@claudio-codebase
Claudio Castillo (claudio-codebase) marked this pull request as ready for review October 2, 2026 23:30
@github-actions

github-actions Bot commented Oct 5, 2026

Copy link
Copy Markdown
Contributor

Azure Static Web Apps: Your stage site is ready! Visit it here: https://calm-wave-0c4fb390f-4088.eastus2.4.azurestaticapps.net

@github-actions

github-actions Bot commented Oct 5, 2026

Copy link
Copy Markdown
Contributor

Azure Static Web Apps: Your stage site is ready! Visit it here: https://calm-wave-0c4fb390f-4088.eastus2.4.azurestaticapps.net

@github-actions

github-actions Bot commented Oct 5, 2026

Copy link
Copy Markdown
Contributor

Azure Static Web Apps: Your stage site is ready! Visit it here: https://calm-wave-0c4fb390f-4088.eastus2.4.azurestaticapps.net

Claudio Castillo and others added 2 commits October 16, 2026 11:42
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@github-actions

Copy link
Copy Markdown
Contributor

Azure Static Web Apps: Your stage site is ready! Visit it here: https://calm-wave-0c4fb390f-4088.eastus2.4.azurestaticapps.net

@github-actions

Copy link
Copy Markdown
Contributor

Azure Static Web Apps: Your stage site is ready! Visit it here: https://calm-wave-0c4fb390f-4088.eastus2.4.azurestaticapps.net

@claudio-codebase
Claudio Castillo (claudio-codebase) merged commit 5467ad9 into dev Oct 16, 2026
24 checks passed
@claudio-codebase
Claudio Castillo (claudio-codebase) deleted the fix/feedback_keyboard_nav branch October 16, 2026 22:48
@sonarqubecloud

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants