fix(peer): finalize hibernation iterators instead of throwing on cleanup - #49
Merged
Merged
Conversation
HibernationAsyncIteratorClass no longer throws when its cleanup runs (return/throw/asyncDispose), and ServerPeer now finalizes the iterator right after invoking the hibernation callback, even when the callback rejects.
@standardserver/aws-lambda
@standardserver/bun
@standardserver/core
@standardserver/deno
@standardserver/fastify
@standardserver/fetch
@standardserver/node
@standardserver/peer
@standardserver/shared
commit: |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Contributor
Merging this PR will not alter performance
Comparing Footnotes
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cleaning up a
HibernationAsyncIteratorClass(viareturn,throw, or async dispose) no longer throws, and the server now finalizes the iterator right after the hibernation callback runs, so it always ends up properly closed.Fixes
HibernationAsyncIteratorClasscleanup was throwing "Cannot use hibernating iterator directly" on cancellation, so any generic code path that closed the iterator would blow up. Only direct iteration vianext()still throws.ServerPeernow callsreturn()on the iterator in afinallyafter invoking the hibernation callback, so the iterator is finalized even when the callback rejects; the rejection still propagates and cancels the request as before.Testing
{ done: true }after handling, for both successful and rejecting callbacks.