fix(node,fastify): handle synchronous throws on the response-send path - #51
Merged
Conversation
A synchronous throw while applying status/headers or sending (e.g. an invalid header value, or FST_ERR_BAD_STATUS_CODE in fastify) previously rejected the promise while leaving the connection neither ended nor destroyed and the built body stream leaked. Both adapters now wrap the send sequence in try/catch: the body stream is destroyed, the node response socket is destroyed so the client isn't left hanging, and the promise rejects with the original error. Fastify keeps reply.raw intact so its error handler can still respond. canWriteToNodeResponse also treats headersSent as non-writable, so responses whose headers were flushed upstream take the graceful not-writable path instead of throwing ERR_HTTP_HEADERS_SENT.
@standardserver/aws-lambda
@standardserver/bun
@standardserver/core
@standardserver/deno
@standardserver/fastify
@standardserver/fetch
@standardserver/node
@standardserver/peer
@standardserver/shared
commit: |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Contributor
Merging this PR will not alter performance
Comparing Footnotes
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A synchronous throw while sending a response (an invalid header value in the node adapter,
FST_ERR_BAD_STATUS_CODEin fastify) used to reject the promise while leaving the connection neither ended nor destroyed and the already-built body stream leaked. In the node adapter the client would hang until it gave up, since Node has no default response-send timeout.Fixes
ReadableStreamgets itscancel()called instead of staying locked), and the promise rejects with the original error.reply.rawintact — its error handler still delivers the 500.canWriteToNodeResponsenow treatsheadersSentas non-writable, so a response whose headers were flushed upstream takes the graceful not-writable path instead of throwingERR_HTTP_HEADERS_SENTwith headers half-applied.Testing