fix: Support Field defined via typing_extensions.Annotated - #58
Merged
pawamoy merged 2 commits intoAug 29, 2026
Merged
Conversation
pawamoy
approved these changes
Aug 29, 2026
pawamoy
left a comment
Member
There was a problem hiding this comment.
Looks like a no-brainer, thanks 🙂
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For reviewers
Description of the change
#46 checks
canonical_path == "typing.Annotated", sotyping_extensions.Annotated[int, Field(description="...", le=10)]never enters that branch. The description and constraints are dropped.Now matches
typing_extensions.Annotatedtoo. New test mirrorstest_annotated_fieldswithtyping_extensions, and also asserts that a constraint declared insideAnnotatedis collected.Relevant resources
Annotatedcauses fields to not show up with description #37