Skip to content

Add support for safety DAG 1.2 - #1626

Merged
rogthefrog merged 32 commits into
mainfrom
1621-safety-version
Sep 1, 2026
Merged

Add support for safety DAG 1.2#1626
rogthefrog merged 32 commits into
mainfrom
1621-safety-version

Conversation

@rogthefrog

@rogthefrog rogthefrog commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@rogthefrog
rogthefrog requested a review from a team as a code owner August 26, 2026 23:30
@github-actions

github-actions Bot commented Aug 26, 2026

Copy link
Copy Markdown

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

@rogthefrog
rogthefrog deployed to Scheduled Testing August 26, 2026 23:32 — with GitHub Actions Active
dhosterman
dhosterman approved these changes Aug 27, 2026
View reviewed changes

@dhosterman dhosterman left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@rogthefrog
refactor hazards so they mirror the test class structure and we don't…
7107a2e 
… have to wonder what's shared and what's not
@rogthefrog rogthefrog changed the title empty response node was left out of the migration from modelplane flights Add support for safety DAG 1.2 Aug 29, 2026
@rogthefrog
rogthefrog requested a review from bkorycki August 29, 2026 02:47
@rogthefrog rogthefrog mentioned this pull request Aug 29, 2026
Open
wpietri
wpietri approved these changes Aug 29, 2026
View reviewed changes
Comment thread src/modelgauge/prompt_sets.py Outdated
Comment thread src/modelbench/benchmarks.py Outdated
@rogthefrog
TestItem context is a SafeTestItemContext, and we need to convert to …
de4ec13 
…a dict for the side info to include its data
bkorycki
bkorycki reviewed Aug 31, 2026
View reviewed changes
Comment thread src/modelgauge/annotators/composer/empty_response.py
Comment thread src/modelgauge/annotators/composer/empty_response.py
Comment thread src/modelgauge/personas.py
Comment thread src/modelgauge/tests/safe_v1.py
Comment thread src/modelbench/hazards.py Outdated
@rogthefrog
rogthefrog deployed to Scheduled Testing September 1, 2026 18:30 — with GitHub Actions Active
@rogthefrog
rogthefrog deployed to Scheduled Testing September 1, 2026 18:44 — with GitHub Actions Active
@rogthefrog
rogthefrog deployed to Scheduled Testing September 1, 2026 22:45 — with GitHub Actions Active
@bkorycki
bkorycki deployed to Scheduled Testing September 1, 2026 22:51 — with GitHub Actions Active
@rogthefrog
rogthefrog deployed to Scheduled Testing September 1, 2026 23:11 — with GitHub Actions Active
@rogthefrog
rogthefrog merged commit c6ff000 into main Sep 1, 2026
3 checks passed
@rogthefrog
rogthefrog deleted the 1621-safety-version branch September 1, 2026 23:28

This branch was successfully deployed

1 active deployment
Scheduled Testing — 5fe85015 Deployed Sep 1, 2026 by rogthefrog via build #2516
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bkorycki bkorycki bkorycki left review comments
@wpietri wpietri wpietri approved these changes
@dhosterman dhosterman dhosterman approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rogthefrog @wpietri @dhosterman @bkorycki