Create full OpenRouter SUT factory - #1666
Merged
Merged
Conversation
This should fix the UIDs
|
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
wpietri
approved these changes
Sep 16, 2026
wpietri
left a comment
wpietri
left a comment
Contributor
There was a problem hiding this comment.
Looks like a step forward to me, but since the mise.toml is a peer to pyproject.toml, I'd make it a non-hidden file.
rogthefrog
approved these changes
Sep 16, 2026
|
|
||
| OPENAI_SUT_FACTORIES["openrouter"] = OpenRouterSUTFactory | ||
| def list_suts(self) -> list[SUTDefinition] | None: | ||
| data = self.client.models.list().data |
Contributor
There was a problem hiding this comment.
Should this be in a try block?
Collaborator
Author
There was a problem hiding this comment.
They aren't in the other list_sut methods, so it looks like the behavior we're after is for them to fail fast and loudly.
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should fix the UIDs.
Now, the following work:
uv run modelbench benchmark general -m 1 -s qwen/qwen3.8-max-0902:openrouter -v 1.2 --prompt-set practice --evaluator privateuv run modelbench benchmark general -m 1 -s qwen/qwen3.8-max-0902:alibaba:openrouter -v 1.2 --prompt-set practice --evaluator privateI've added a simple
.mise.tomlfile, but if we don't want to start heading in that direction, I can remove it.