Repository navigation
add request ID for log event correlation; add more error logging - #1675
Merged
Merged
Conversation
|
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
rogthefrog
marked this pull request as draft
September 23, 2026 21:54
…st_id we already use
rogthefrog
marked this pull request as ready for review
September 23, 2026 22:23
Contributor
|
How would you feel about a request ID that starts with seconds since epoch and then has random hex? I find it handy when looking at logs and wire dumps to know roughly when something is from. |
Contributor
Author
Certainly! It also helps eyeball whether something happened before something else. I'll make the change. |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add an ID header to requests so we can correlate events between services more easily. This goes with a matching PR in sugar.
https://github.com/mlcommons/sugar/pull/705
Also add a bunch more error logging.