Repository navigation
Fix dynamic SUT listing - #1678
Merged
Merged
Conversation
wpietri
had a problem deploying
to
Scheduled Testing
September 24, 2026 13:26 — with 
GitHub Actions
Failure
GitHub Actions
Failure
|
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
rogthefrog
approved these changes
Sep 24, 2026
rogthefrog
left a comment
rogthefrog
left a comment
Contributor
There was a problem hiding this comment.
The global var hack is clever. I can't wait to remove all those globals and the side-effects the rest of the code depends on.
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Turns out most of the problems here were obsolete dynamic SUT factories, so I removed them.
This also contains code to defer initialization of the
SUT_FACTORYglobal variable. Once that's in I'll have a PR for a script that reports on the status of dynamic SUTs.