Repository navigation
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (1)
Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 1 remain after this review. WalkthroughThe platform resolver maps Priority: ➖ Normal Merge Risk: 🟡 Moderate · up to Default device listing on Termux can fail because the mapped binary packages are omitted during installation. Provide an Android-installable package before merging. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On Termux, Node reports
process.platformasandroid, sogetPlatformBinarythrowsUnsupported platform: android-arm64and tests fail at device allocation.Fix
Map
android-arm64andandroid-x64to the existing linux binaries, since they run on Android as-is.Testing
Tested on Termux (android-arm64): the
Unsupported platformerror is gone and mobilecli launches.Related: mobile-next/mobilecli#499, which allows
androidin the linux platform packages'osfield so npm installs them.