Skip to content

Support Android (Termux) by mapping android platform to linux binaries - #394

Open
Jobians wants to merge 1 commit into
mobile-next:mainfrom
Jobians:patch-1
Open

Jobians wants to merge 1 commit into
mobile-next:mainfrom
Jobians:patch-1

Conversation

@Jobians

@Jobians Jobians commented Oct 6, 2026

Copy link
Copy Markdown

Problem

On Termux, Node reports process.platform as android, so getPlatformBinary throws Unsupported platform: android-arm64 and tests fail at device allocation.

Fix

Map android-arm64 and android-x64 to the existing linux binaries, since they run on Android as-is.

Testing

Tested on Termux (android-arm64): the Unsupported platform error is gone and mobilecli launches.

Related: mobile-next/mobilecli#499, which allows android in the linux platform packages' os field so npm installs them.

@coderabbitai

coderabbitai Bot commented Oct 6, 2026 •

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 965645fc-e3e2-4268-ba58-f27c4f5618cd
📥 Commits

Reviewing files that changed from the base of the PR and between b81210f and 10caa97.

📒 Files selected for processing (1)
  • packages/driver-mobilecli/src/resolve-binary.ts

Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 1 remain after this review.


Walkthrough

The platform resolver maps android-arm64 to the Linux ARM64 binary package and android-x64 to the Linux x64 binary package.

Priority: ➖ Normal

Merge Risk: 🟡 Moderate · up to 10caa

Default device listing on Termux can fail because the mapped binary packages are omitted during installation. Provide an Android-installable package before merging.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly states the main change: mapping Android platforms to Linux binaries for Termux support.
Description check ✅ Passed The description explains the Termux platform issue, the Android-to-Linux binary mapping, and the reported test result.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR

Comment @coderabbitai help to get the list of available commands.

@Jobians

Jobians commented Oct 6, 2026

Copy link
Copy Markdown
Author

@gmegidish

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant