Update autoharness_analyzer for current AutoHarnessSkipReason variants - #680
Open
srivatsansamraj wants to merge 1 commit into
Open
Conversation
Kani changed GenericFn to carry a String (model-checking/kani#4679) and added RequiresBoundedArguments (model-checking/kani#4691). The analyzer keeps its own copy of the enum, which did not follow, so it fails to deserialize metadata from current Kani. Match the enum, normalize the old bare "GenericFn" form so CI on the pinned Kani keeps working, and report RequiresBoundedArguments in its own table. Resolves model-checking#679
Author
|
@Tianshu-Huang @acearyanarun @CYJ904 @wodex1nhaoIeng Opened #679 for this; this PR is the fix. Feel free to take a look and verify when you get a chance. |
srivatsansamraj
marked this pull request as ready for review
September 8, 2026 06:54
|
Looks good to me |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The analyzer keeps its own copy of
AutoHarnessSkipReasonand fails to deserialize metadata from current Kani, which changedGenericFntoGenericFn(String)(model-checking/kani#4679) and addedRequiresBoundedArguments(model-checking/kani#4691).kani_metadata, keeping thestrumstrings identical so table text matcheskani autoharness --list."GenericFn"to{"GenericFn": ""}beforefrom_value, since CI builds the pinned Kani, which still writes the old form.RequiresBoundedArgumentsin its own type-category table instead of folding it into the missing-implementation one; the two need different remediation.--bounded-argumentsin the README.Verified with three hand-built
kani-metadata.jsonfixtures (old format,GenericFnwith payload,RequiresBoundedArguments): before the change they behave as described in #679, after it all three pass.cargo testcovers the same three cases inline. Not run against a full std sweep.Resolves #679
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.