docs(decisions): decline folding ContextRegistry into Container#330
Merged
Conversation
Record the ruling on Candidate 5 from the 2026-07-15 architecture review: keep ContextRegistry as its own module. Though it is the shallowest of the four registries (~18 lines, a dict wrapper), containers.md documents a deliberate shared-vs-per-container model in which ContextRegistry sits symmetric with CacheRegistry as one of the two per-container registries. Its shallowness reflects less mechanism, not a broken abstraction. The deletion test is misleading: the code-complexity vanishes, but the conceptual slot does not — folding turns a named registry into an unnamed inline dict, breaks a documented table, and grows the largest file for ~18 lines with zero actual friction. Revisit trigger: the four-registry model is restructured, or concrete friction emerges in the delegation. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Records the ruling on Candidate 5 from the 2026-07-15 architecture review after grilling: keep
ContextRegistryas its own module; do not fold it intoContainer.ADR:
planning/decisions/2026-07-15-fold-context-registry-declined.md.Why decline
architecture/containers.mdhas a "Registry sharing" section organizing the four registries by shared-across-tree (ProvidersRegistry,OverridesRegistry) vs per-container (CacheRegistry,ContextRegistry).ContextRegistrysits symmetric withCacheRegistry— not incidental co-location.Containerstill has per-container context state; folding just turns a named registry into an unnamed inline dict, breaks the containers.md table, and grows the already-largest file.Revisit trigger: the four-registry model is restructured, or concrete friction emerges in the
Container → ContextRegistrydelegation.Closes out the review: candidates 1, 2, 4 built; 3 and 5 declined with ADRs. No code change.
just check-planningpasses.🤖 Generated with Claude Code