refactor(cart-customer): thin Cart/Customer facades via Services managers - #406
Open
Ibochkarev wants to merge 6 commits into
Open
refactor(cart-customer): thin Cart/Customer facades via Services managers#406Ibochkarev wants to merge 6 commits into
Ibochkarev wants to merge 6 commits into
Conversation
Ibochkarev
added
priority: high
Ibochkarev
force-pushed
the
feat/issue-362-cart-customer-facade
branch
6 times, most recently
from
July 29, 2026 11:33
d95b351 to
ed2198d
Compare
Ibochkarev
force-pushed
the
feat/issue-362-cart-customer-facade
branch
from
August 1, 2026 09:32
a2d4053 to
3519b77
Compare
Move cart mutations and customer field/order resolution out of Controllers facades so they match the Order + managers pattern without breaking web API.
Drop redundant is_numeric on int cart id; use getOrder() instead of magic order property.
Ibochkarev
force-pushed
the
feat/issue-362-cart-customer-facade
branch
from
August 2, 2026 02:34
3519b77 to
47b6169
Compare
Fix PHP 8.2 fatal when modX stub declares typed lexicon().
Anonymous subclasses must not redeclare parent properties with types when ModxStub uses untyped $services (PHP 8.2 fatal).
Drop typed $services/$lexicon on anonymous modX subclasses when ModxStub already declares untyped parent properties.
Cart facade delegates mutations; integration harness must wire the handler.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Описание
Вынес пайплайны мутаций корзины и работы с покупателем из толстых facade
Controllers/Cart/Cart.phpиControllers/Customer/Customer.phpв сервисы по образцуOrder+ managers. Web API ($ms3->cart/$ms3->customer) и события (msOnBeforeAddToCart, customer events) сохранены.Новые сервисы:
CartMutationHandler,CustomerFieldManager,CustomerOrderResolver. Регистрация DI:ms3_cart_mutation_handler,ms3_customer_field_manager,ms3_customer_order_resolver. Status для ответов мутаций корзины считает handler; facade только синхронизируетdraft/cart.Тип изменений
Связанные Issues
Closes #362
Как это было протестировано?
Команды (Gate E):
php -lпо затронутым PHP — exit 0php tests/CartCustomerFacadeStructureTest.php— exit 0 (длина facade-методов ≤55, ключи DI, events/status в Services)Конфигурация тестирования:
feat/issue-362-cart-customer-facadeСкриншоты (если применимо)
Чеклист
Дополнительные заметки
Controllers/*→Domain/*намеренно вне scope (как в issue).countи ownership status в handler.