fix(vue): unwrap пустого object/data в request.js - #466
Open
Ibochkarev wants to merge 1 commit into
Open
Conversation
Ibochkarev
force-pushed
the
fix/issue-388-request-unwrap
branch
from
July 29, 2026 02:05
ac8b30b to
a16e07c
Compare
Empty {} or [] payloads were falling through to the full success envelope,
so grid callers expecting .results saw Invalid response without a toast.
Ibochkarev
force-pushed
the
fix/issue-388-request-unwrap
branch
from
July 29, 2026 11:31
a16e07c to
89ab5f5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Описание
В
request.jsunwrap отбрасывал payload, еслиobjectбыл{}илиdata— пустым массивом (Object.keys().length/array.length > 0). Вместо inner payload callers получали connector envelope{ success, message, … }. Гриды с проверкойresponse.resultsпопадали в ветку «Invalid response» без error toast.Добавлена функция
unwrapResponsePayload(): при наличии ключаobject/dataс значением!= nullвозвращается payload (включая{},[], falsy scalar). Используется вrequest()иupload().Тип изменений
Связанные Issues
Closes #388
Refs #370
Как это было протестировано?
CI job
vueдополнен шагомnpm run test:smoke.Конфигурация тестирования:
Скриншоты (если применимо)
.results, console.error{}/{ results: [], total: 0 }Чеклист
response.object || responseсовместим)Дополнительные заметки
{ success, message }безobject/data(delete и т.п.) по-прежнему возвращают envelope — намеренно, чтобы не ломать void-операции.if (response.results)приobject: {}всё ещё покажут пустой грид и console.error; backend должен отдавать{ results, total }.request()иupload()— follow-up.