Удалить deprecated pass-through OrderService/Customer - #489
Open
Ibochkarev wants to merge 2 commits into
Open
Conversation
Drop handleOrderSave/removeOrder and Customer::getId wrappers after confirming zero in-repo callers; core uses msOrder::save/remove and Customer::getOrCreate directly. Closes #357
Ibochkarev
added
priority: low
Move tests/DeprecatedPassThroughRemovedTest.php into tests/Unit/Regression/ as a PHPUnit class and narrow assertions to method_exists + ReflectionClass::hasMethod on OrderService and Customer, dropping the full-tree grep that was prone to false positives.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Описание
Удалены тонкие
@deprecatedобёртки без собственной логики после аудита callers в репозитории (0 внутренних вызовов):OrderService::handleOrderSave()→ канон:msOrder::save()OrderService::removeOrder()→ канон:msOrder::remove()Customer::getId()→ канон:Customer::getOrCreate()Добавлен smoke-тест
DeprecatedPassThroughRemovedTest, который не допускает возврат pass-through в core.Тип изменений
Связанные Issues
Closes #357
Аудит callers
handleOrderSaveremoveOrderCustomer::getIdВнешние extras: если вызывали эти методы — мигрировать на канонические API выше.
Как это было протестировано?
Конфигурация: PHP 8.4.17, branch
refactor/issue-357-remove-deprecated-passthroughЧеклист