Skip to content

Clear not_landed needinfos after patches land - #3004

Open
loganrosen wants to merge 1 commit into
mozilla:masterfrom
loganrosen:loganrosen-clear-not-landed-needinfos
Open

Clear not_landed needinfos after patches land#3004
loganrosen wants to merge 1 commit into
mozilla:masterfrom
loganrosen:loganrosen-clear-not-landed-needinfos

Conversation

@loganrosen

Copy link
Copy Markdown

Closes #3003.

Summary

  • track the exact Phabricator revisions that caused each not_landed needinfo
  • clear only open needinfo flags attributable to the rule when every tracked revision is published or the bug is closed
  • migrate existing tracked needinfos conservatively and retire completed or inaccessible records
  • cover landing, resolution, legacy tracking, repeated-run cleanup, and unrelated-flag safety cases

Testing

  • uv run pytest -q tests/rules/test_not_landed.py tests/test_bzcleaner.py tests/test_db.py
  • uv run pre-commit run --files bugbot/rules/not_landed.py tests/rules/test_not_landed.py

Checklist

  • Type annotations added to new functions
  • Docs added to functions touched in main classes
  • Dry-run produced the expected results
  • The to-be-announced tag added if this is worth announcing

Track the exact Phabricator revisions behind each not_landed needinfo and clear only the matching BugBot-created flags after those revisions publish or the bug closes. Retire completed tracking records and cover landing, resolution, legacy, and unrelated-flag safety cases.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[not_landed] Clear BugBot needinfos after the patch lands

1 participant