Repository navigation
Fix cargo test when running in a terminal - #19
Merged
Merged
Conversation
Make existing tests deterministically use the no-tty path. Previously, running cargo test in a terminal would block on reading stdin unless </dev/null was used. This was caused by tests reaching the interactive path for missing parameters. Use this as an opportunity to define some more tests, though none that requires true interaction with stdin.
JohanLorenzo
approved these changes
Jun 25, 2026
JohanLorenzo
left a comment
JohanLorenzo
left a comment
Collaborator
There was a problem hiding this comment.
Thanks! I did have issues with some of these e2e tests too but I thought I had them all fixed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make existing tests deterministically use the no-tty path. Previously, running cargo test in a terminal would block on reading stdin unless </dev/null was used. This was caused by tests reaching the interactive path for missing parameters.
Use this as an opportunity to define some more tests, though none that requires true interaction with stdin.