Skip to content

Fix dashboard widget query reassignment - #57

Merged
JohanLorenzo merged 13 commits into
mozilla:mainfrom
JohanLorenzo:fix/dashboard-widget-query-reassignment
Oct 6, 2026
Merged

JohanLorenzo merged 13 commits into
mozilla:mainfrom
JohanLorenzo:fix/dashboard-widget-query-reassignment

Conversation

@JohanLorenzo

Copy link
Copy Markdown
Collaborator

Redash’s widget update endpoint preserves the widget’s attached query, so deploying a changed query_id could leave the dashboard showing the old query. I recreate the widget when the YAML query or visualization differs, resolving the visualization against the selected query. The old widget is deleted after creation, and the replacement is cleaned up if deletion fails. Unchanged visualization selections still use the update endpoint.

I verified the query reassignment end to end on a disposable draft dashboard and archived that draft afterward. The original dashboard remains unchanged.

@JohanLorenzo
JohanLorenzo force-pushed the fix/dashboard-widget-query-reassignment branch 3 times, most recently from 5a53ef8 to 4c86182 Compare October 6, 2026 07:41
@JohanLorenzo
JohanLorenzo force-pushed the fix/dashboard-widget-query-reassignment branch 2 times, most recently from 4b0ea5f to 801c833 Compare October 6, 2026 08:25
@JohanLorenzo
JohanLorenzo force-pushed the fix/dashboard-widget-query-reassignment branch from 801c833 to 0cdff11 Compare October 6, 2026 10:22
@JohanLorenzo
JohanLorenzo merged commit 2233ff8 into mozilla:main Oct 6, 2026
6 checks passed
@JohanLorenzo
JohanLorenzo deleted the fix/dashboard-widget-query-reassignment branch October 6, 2026 12:03
@JohanLorenzo JohanLorenzo mentioned this pull request Oct 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant