Skip to content

Reject invalid schedule time on deploy - #65

Merged
JohanLorenzo merged 1 commit into
mozilla:mainfrom
JohanLorenzo:schedule-time-validation
Oct 9, 2026
Merged

JohanLorenzo merged 1 commit into
mozilla:mainfrom
JohanLorenzo:schedule-time-validation

Conversation

@JohanLorenzo

@JohanLorenzo JohanLorenzo commented Oct 9, 2026 •

Copy link
Copy Markdown
Collaborator

deploy now rejects any schedule.time that isn't HH:MM before it sends a request. The error names the file and the bad value.

stmo-cli writes time unquoted, so 12:00 is valid YAML 1.1 only as a sexagesimal number.

Quoting on write is not an option here: serde_yaml does not quote individual fields, so the validation runs on deploy instead.

Evidence, run in a temporary directory against a dead local port:

  • time: 720 exits 1 with schedule time '720' is not HH:MM, without connecting.
  • time: '12:00' passes validation and fails only at the connection step.

@JohanLorenzo
JohanLorenzo force-pushed the schedule-time-validation branch 2 times, most recently from 3b7ea28 to b23f386 Compare October 9, 2026 09:29
@JohanLorenzo
JohanLorenzo force-pushed the schedule-time-validation branch from b23f386 to 76be0f4 Compare October 9, 2026 09:30
@JohanLorenzo
JohanLorenzo marked this pull request as ready for review October 9, 2026 09:40
@JohanLorenzo
JohanLorenzo merged commit c957b07 into mozilla:main Oct 9, 2026
6 checks passed
@JohanLorenzo
JohanLorenzo deleted the schedule-time-validation branch October 9, 2026 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant