context_angle: remove the D3D9 renderer - #18328
Open
JuliusBairaktaris wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
|
? why vendor the constant when the backend was removed, whatever it's used for won't work |
ANGLE removed its D3D9 backend along with EGL_PLATFORM_ANGLE_TYPE_D3D9_ANGLE, so context_angle.c no longer builds against current ANGLE headers. Signed-off-by: Julius Bairaktaris <julius@bairaktaris.de>
JuliusBairaktaris
force-pushed
the
angle-d3d9-define
branch
from
August 1, 2026 03:39
ab668d7 to
62bbfd6
Compare
Author
|
Fair point, dropped the backend instead of vendoring the constant. Also removes the option value and its documentation. Verified context_angle.c still compiles with |
JuliusBairaktaris
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ANGLE removed its D3D9 backend along with
EGL_PLATFORM_ANGLE_TYPE_D3D9_ANGLE, socontext_angle.cno longer builds against current ANGLE headers.CI does not catch it because the mingw job installs no ANGLE headers, so
egl-angleauto-detects to disabled and the file is never built.Also drops the
d3d9value of--angle-rendererand its documentation. Verified the file still compiles with-Degl-angle-win32=enabledagainst current headers.