Repository navigation
Add devcontainer and Copilot setup steps - #72
Merged
Merged
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
📊 Benchmark Comparison Results✅ All benchmarks within noise104 benchmarks compared, no significant changes detected. Legend: ✅ Faster (>5%) · |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Getting a working environment for hexhamming means installing Rust, maturin, the pinned ruff and pytest, then building the extension. This PR automates that for both local containers and the Copilot cloud agent, so neither has to work it out by trial and error.
Copilot setup steps (
.github/workflows/copilot-setup-steps.yml)pythonpackage.yml.ruff==0.16.8(matching thelintjob), maturin, pytest and pytest-benchmark, then runspip install ..cargo test --no-default-features --no-run) so the agent's first test run is quick.Swatinem/rust-cache, pinned to the v2.9.3 SHA. This is the one action the existing workflows don't already use.Devcontainer (
.devcontainer/)mcr.microsoft.com/devcontainers/python:3.14with the Rust (rustfmt, clippy, rust-analyzer) and GitHub CLI features.post-create.shinstalls the same Python tooling, installs the package and runscargo fetch..github/copilot-instructions.mdnow mentions both, including that the ruff pin must stay in sync with thelintjob.Review notes: the workflow runs on this PR through its
pull_requestpath trigger, which is its only end-to-end check so far. The devcontainer has not been built, since Docker wasn't available locally. Locally, the devcontainer JSON parses, the script passesbash -n, and the Rust test pre-build succeeds.