Skip to content

Disable chatty connection logging by default - #12

Merged
rschlaikjer merged 2 commits into
masterfrom
rs-disable-chatty-logs
Feb 4, 2026
Merged

rschlaikjer merged 2 commits into
masterfrom
rs-disable-chatty-logs

Conversation

@rschlaikjer

@rschlaikjer rschlaikjer commented Feb 3, 2026 •

Copy link
Copy Markdown
Contributor

For servers fielding tens/hundreds of concurrent clients, the connect/disconnect logs flood out more useful information.

Disable them by default, but allow re-enabling them if so desired.

@rschlaikjer
rschlaikjer requested review from SunskyXH and ziyan February 3, 2026 01:22
@ziyan

ziyan commented Feb 3, 2026

Copy link
Copy Markdown
Member

@rschlaikjer Why don't we check existence of log.verbose and use that? This way you can change log level at runtime and allow us to debug in a pinch

@rschlaikjer

Copy link
Copy Markdown
Contributor Author

@rschlaikjer Why don't we check existence of log.verbose and use that? This way you can change log level at runtime and allow us to debug in a pinch

I thought about that but seemed hacky. If we think that's fine then sure. I guess fall back to debug if verbose doesn't exist?

@rschlaikjer
rschlaikjer force-pushed the rs-disable-chatty-logs branch from 50140b1 to 4fd81b9 Compare February 3, 2026 02:07
@rschlaikjer
rschlaikjer merged commit 6543e0f into master Feb 4, 2026
1 check passed
@rschlaikjer
rschlaikjer deleted the rs-disable-chatty-logs branch February 4, 2026 01:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants