Skip to content

Dockerfile is incorrect #129

Description

@pveutin

Hi,

There's an issue in the Dockerfile: the file is downloaded and renamed at the same time, but the checksum computed afterward is looking for the original filename.

Here's a working version with the commands in the correct order:

FROM alpine:3.23.5@sha256:fd791d74b68913cbb027c6546007b3f0d3bc45125f797758156952bc2d6daf40

ARG TARGETARCH=amd64
ARG VERSION=1.8.3

RUN apk add --no-cache ca-certificates gcompat libgcc wget \
    && case "${TARGETARCH}" in \
        amd64|arm64) ;; \
        *) echo "unsupported TARGETARCH: ${TARGETARCH}" >&2; exit 1 ;; \
    esac \
    && cd /usr/local/bin \
    && wget -O "androidqf_linux_${TARGETARCH}_${VERSION}" \
        "https://github.com/mvt-project/androidqf/releases/download/v${VERSION}/androidqf_linux_${TARGETARCH}_${VERSION}" \
    && wget -O /tmp/checksums.txt \
        "https://github.com/mvt-project/androidqf/releases/download/v${VERSION}/checksums.txt" \
    && grep "  androidqf_linux_${TARGETARCH}_${VERSION}$" /tmp/checksums.txt | sha256sum -c - \
    && mv "androidqf_linux_${TARGETARCH}_${VERSION}" androidqf \
    && rm /tmp/checksums.txt \
    && chmod +x /usr/local/bin/androidqf

WORKDIR /acquisition

ENTRYPOINT ["androidqf"]
CMD ["-output", "/output"]

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions